Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Side by Side Diff: chrome/browser/extensions/permissions_updater_unittest.cc

Issue 2257113002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/permissions_updater.h" 5 #include "chrome/browser/extensions/permissions_updater.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/files/file_path.h" 9 #include "base/files/file_path.h"
10 #include "base/json/json_file_value_serializer.h" 10 #include "base/json/json_file_value_serializer.h"
(...skipping 221 matching lines...) Expand 10 before | Expand all | Expand 10 after
232 } 232 }
233 233
234 TEST_F(PermissionsUpdaterTest, RevokingPermissions) { 234 TEST_F(PermissionsUpdaterTest, RevokingPermissions) {
235 InitializeEmptyExtensionService(); 235 InitializeEmptyExtensionService();
236 236
237 ExtensionPrefs* prefs = ExtensionPrefs::Get(profile()); 237 ExtensionPrefs* prefs = ExtensionPrefs::Get(profile());
238 238
239 auto api_permission_set = [](APIPermission::ID id) { 239 auto api_permission_set = [](APIPermission::ID id) {
240 APIPermissionSet apis; 240 APIPermissionSet apis;
241 apis.insert(id); 241 apis.insert(id);
242 return base::WrapUnique(new PermissionSet( 242 return base::MakeUnique<PermissionSet>(apis, ManifestPermissionSet(),
243 apis, ManifestPermissionSet(), URLPatternSet(), URLPatternSet())); 243 URLPatternSet(), URLPatternSet());
244 }; 244 };
245 245
246 auto url_permission_set = [](const GURL& url) { 246 auto url_permission_set = [](const GURL& url) {
247 URLPatternSet set; 247 URLPatternSet set;
248 URLPattern pattern(URLPattern::SCHEME_ALL, url.spec()); 248 URLPattern pattern(URLPattern::SCHEME_ALL, url.spec());
249 set.AddPattern(pattern); 249 set.AddPattern(pattern);
250 return base::WrapUnique(new PermissionSet( 250 return base::MakeUnique<PermissionSet>(
251 APIPermissionSet(), ManifestPermissionSet(), set, URLPatternSet())); 251 APIPermissionSet(), ManifestPermissionSet(), set, URLPatternSet());
252 }; 252 };
253 253
254 { 254 {
255 // Test revoking optional permissions. 255 // Test revoking optional permissions.
256 ListBuilder optional_permissions; 256 ListBuilder optional_permissions;
257 optional_permissions.Append("tabs").Append("cookies").Append("management"); 257 optional_permissions.Append("tabs").Append("cookies").Append("management");
258 ListBuilder required_permissions; 258 ListBuilder required_permissions;
259 required_permissions.Append("topSites"); 259 required_permissions.Append("topSites");
260 scoped_refptr<const Extension> extension = 260 scoped_refptr<const Extension> extension =
261 CreateExtensionWithOptionalPermissions(optional_permissions.Build(), 261 CreateExtensionWithOptionalPermissions(optional_permissions.Build(),
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
357 ->active_permissions() 357 ->active_permissions()
358 .HasExplicitAccessToOrigin(kOrigin)); 358 .HasExplicitAccessToOrigin(kOrigin));
359 EXPECT_TRUE(extension->permissions_data() 359 EXPECT_TRUE(extension->permissions_data()
360 ->withheld_permissions() 360 ->withheld_permissions()
361 .HasExplicitAccessToOrigin(kOrigin)); 361 .HasExplicitAccessToOrigin(kOrigin));
362 EXPECT_TRUE(updater.GetRevokablePermissions(extension.get())->IsEmpty()); 362 EXPECT_TRUE(updater.GetRevokablePermissions(extension.get())->IsEmpty());
363 } 363 }
364 } 364 }
365 365
366 } // namespace extensions 366 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/extensions/navigation_observer.cc ('k') | chrome/browser/extensions/update_install_gate_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698