chrome/browser/extensions/extension_install_prompt_unittest.cc - Issue 2257113002: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_install_prompt_unittest.cc

Issue 2257113002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_install_prompt.cc ('k') | chrome/browser/extensions/extension_message_bubble_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_install_prompt_unittest.cc

diff --git a/chrome/browser/extensions/extension_install_prompt_unittest.cc b/chrome/browser/extensions/extension_install_prompt_unittest.cc

index 62dd137de95bde66e40f3d7934bdf18f65ce0c41..a78e06c3f78dad0d9581398a407389ea540c651e 100644

--- a/chrome/browser/extensions/extension_install_prompt_unittest.cc

+++ b/chrome/browser/extensions/extension_install_prompt_unittest.cc

@@ -120,8 +120,8 @@ TEST_F(ExtensionInstallPromptUnitTest, PromptShowsPermissionWarnings) {

base::RunLoop run_loop;

prompt.ShowDialog(

ExtensionInstallPrompt::DoneCallback(), extension.get(), nullptr,

- base::WrapUnique(new ExtensionInstallPrompt::Prompt(

- ExtensionInstallPrompt::PERMISSIONS_PROMPT)),

+ base::MakeUnique<ExtensionInstallPrompt::Prompt>(

+ ExtensionInstallPrompt::PERMISSIONS_PROMPT),

std::move(permission_set),

base::Bind(&VerifyPromptPermissionsCallback, run_loop.QuitClosure(),

1u, // |regular_permissions_count|.