chrome/browser/extensions/api/socket/combined_socket_unittest.cc - Issue 2257113002: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/socket/combined_socket_unittest.cc

Issue 2257113002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api_unittest.cc ('k') | chrome/browser/extensions/api/socket/socket_api_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/socket/combined_socket_unittest.cc

diff --git a/chrome/browser/extensions/api/socket/combined_socket_unittest.cc b/chrome/browser/extensions/api/socket/combined_socket_unittest.cc

index 72b37c34e06b7e1923cc9010d9ca4caa8f447122..e6d2595d4871143d2e561c607c6ea5eca253b110 100644

--- a/chrome/browser/extensions/api/socket/combined_socket_unittest.cc

+++ b/chrome/browser/extensions/api/socket/combined_socket_unittest.cc

@@ -24,14 +24,14 @@ std::unique_ptr<T> CreateTestSocket(

template <>

std::unique_ptr<TCPSocket> CreateTestSocket(

std::unique_ptr<MockTCPClientSocket> stream) {

- return base::WrapUnique(

- new TCPSocket(std::move(stream), "fake id", true /* is_connected */));

+ return base::MakeUnique<TCPSocket>(std::move(stream), "fake id",

+ true /* is_connected */);

}

template <>

std::unique_ptr<TLSSocket> CreateTestSocket(

std::unique_ptr<MockTCPClientSocket> stream) {

- return base::WrapUnique(new TLSSocket(std::move(stream), "fake id"));

+ return base::MakeUnique<TLSSocket>(std::move(stream), "fake id");

}

class CombinedSocketTest : public testing::Test {