chrome/browser/extensions/api/tabs/tabs_event_router.cc - Issue 2257113002: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/tabs/tabs_event_router.cc

Issue 2257113002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/storage/sync_storage_backend.cc ('k') | chrome/browser/extensions/api/tabs/windows_event_router.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/tabs/tabs_event_router.cc

diff --git a/chrome/browser/extensions/api/tabs/tabs_event_router.cc b/chrome/browser/extensions/api/tabs/tabs_event_router.cc

index f11e908116d8cc7e77aea544b49ce4ae724f6929..6f17b79f02baff3c8fdbcdd1f705a830f74c8404 100644

--- a/chrome/browser/extensions/api/tabs/tabs_event_router.cc

+++ b/chrome/browser/extensions/api/tabs/tabs_event_router.cc

@@ -163,7 +163,7 @@ void TabsEventRouter::RegisterForTabNotifications(WebContents* contents) {

int tab_id = ExtensionTabUtil::GetTabId(contents);

DCHECK(tab_entries_.find(tab_id) == tab_entries_.end());

- tab_entries_[tab_id] = base::WrapUnique(new TabEntry(this, contents));

+ tab_entries_[tab_id] = base::MakeUnique<TabEntry>(this, contents);

}

void TabsEventRouter::UnregisterForTabNotifications(WebContents* contents) {