chrome/browser/extensions/api/identity/identity_apitest.cc - Issue 2257113002: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/identity/identity_apitest.cc

Issue 2257113002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/hotword_private/hotword_private_apitest.cc ('k') | chrome/browser/extensions/api/image_writer_private/operation_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/identity/identity_apitest.cc

diff --git a/chrome/browser/extensions/api/identity/identity_apitest.cc b/chrome/browser/extensions/api/identity/identity_apitest.cc

index 6a92142e9ab5acb52af6a9c0971ad362151a01f0..f08afe7215c1f2534bd1536a266189ebe0c65c59 100644

--- a/chrome/browser/extensions/api/identity/identity_apitest.cc

+++ b/chrome/browser/extensions/api/identity/identity_apitest.cc

@@ -313,7 +313,7 @@ class FakeGetAuthTokenFunction : public IdentityGetAuthTokenFunction {

void set_mint_token_result(TestOAuth2MintTokenFlow::ResultType result_type) {

set_mint_token_flow(

- base::WrapUnique(new TestOAuth2MintTokenFlow(result_type, this)));

+ base::MakeUnique<TestOAuth2MintTokenFlow>(result_type, this));

}

void set_scope_ui_failure(GaiaWebAuthFlow::Failure failure) {

@@ -1249,8 +1249,7 @@ IN_PROC_BROWSER_TEST_F(GetAuthTokenFunctionTest, NoninteractiveShutdown) {

scoped_refptr<FakeGetAuthTokenFunction> func(new FakeGetAuthTokenFunction());

func->set_extension(extension.get());

- func->set_mint_token_flow(

- base::WrapUnique(new TestHangOAuth2MintTokenFlow()));

+ func->set_mint_token_flow(base::MakeUnique<TestHangOAuth2MintTokenFlow>());

RunFunctionAsync(func.get(), "[{\"interactive\": false}]");

// After the request is canceled, the function will complete.