chrome/browser/extensions/api/management/chrome_management_api_delegate.cc - Issue 2257113002: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/management/chrome_management_api_delegate.cc

Issue 2257113002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/image_writer_private/operation_manager_unittest.cc ('k') | chrome/browser/extensions/api/management/management_api_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/management/chrome_management_api_delegate.cc

diff --git a/chrome/browser/extensions/api/management/chrome_management_api_delegate.cc b/chrome/browser/extensions/api/management/chrome_management_api_delegate.cc

index 85896d4d402df1151d0054e3198d7993178d15e7..27f2b5fad7d700dbcd4cee895ad8982b27e75bd8 100644

--- a/chrome/browser/extensions/api/management/chrome_management_api_delegate.cc

+++ b/chrome/browser/extensions/api/management/chrome_management_api_delegate.cc

@@ -61,7 +61,7 @@ class ManagementSetEnabledFunctionInstallPromptDelegate

OnInstallPromptDone,

weak_factory_.GetWeakPtr()),

extension, nullptr,

- base::WrapUnique(new ExtensionInstallPrompt::Prompt(type)),

+ base::MakeUnique<ExtensionInstallPrompt::Prompt>(type),

ExtensionInstallPrompt::GetDefaultShowDialogCallback());

}

~ManagementSetEnabledFunctionInstallPromptDelegate() override {}

@@ -226,7 +226,7 @@ ChromeManagementAPIDelegate::SetEnabledFunctionDelegate(

std::unique_ptr<extensions::RequirementsChecker>

ChromeManagementAPIDelegate::CreateRequirementsChecker() const {

- return base::WrapUnique(new extensions::ChromeRequirementsChecker());

+ return base::MakeUnique<extensions::ChromeRequirementsChecker>();

}

std::unique_ptr<extensions::UninstallDialogDelegate>