chrome/browser/extensions/api/permissions/permissions_api.cc - Issue 2257113002: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/permissions/permissions_api.cc

Issue 2257113002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/omnibox/omnibox_api.cc ('k') | chrome/browser/extensions/api/permissions/permissions_api_helpers.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/permissions/permissions_api.cc

diff --git a/chrome/browser/extensions/api/permissions/permissions_api.cc b/chrome/browser/extensions/api/permissions/permissions_api.cc

index ef8ff5a5f138f7af4fc88651b01443d944973cd6..0a8222f08afb5d492d7a808b0da7371a2cbc59ec 100644

--- a/chrome/browser/extensions/api/permissions/permissions_api.cc

+++ b/chrome/browser/extensions/api/permissions/permissions_api.cc

@@ -239,9 +239,8 @@ bool PermissionsRequestFunction::RunAsync() {

install_ui_.reset(new ExtensionInstallPrompt(GetAssociatedWebContents()));

install_ui_->ShowDialog(

base::Bind(&PermissionsRequestFunction::OnInstallPromptDone, this),

- extension(), nullptr,

- base::WrapUnique(new ExtensionInstallPrompt::Prompt(

- ExtensionInstallPrompt::PERMISSIONS_PROMPT)),

+ extension(), nullptr, base::MakeUnique<ExtensionInstallPrompt::Prompt>(

+ ExtensionInstallPrompt::PERMISSIONS_PROMPT),

requested_permissions_->Clone(),

ExtensionInstallPrompt::GetDefaultShowDialogCallback());

}