chrome/browser/extensions/extension_service_unittest.cc - Issue 2257113002: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_service_unittest.cc

Issue 2257113002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_service_sync_unittest.cc ('k') | chrome/browser/extensions/extension_web_ui_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_service_unittest.cc

diff --git a/chrome/browser/extensions/extension_service_unittest.cc b/chrome/browser/extensions/extension_service_unittest.cc

index 711330f27d3afdb0d4fe22e0f3b419bbed4605ea..83f166412bded5402c48197f642a64e6e95b227e 100644

--- a/chrome/browser/extensions/extension_service_unittest.cc

+++ b/chrome/browser/extensions/extension_service_unittest.cc

@@ -5983,7 +5983,7 @@ TEST_F(ExtensionServiceTest, ConcurrentExternalLocalFile) {

// An external provider starts installing from a local crx.

std::unique_ptr<ExternalInstallInfoFile> info(new ExternalInstallInfoFile(

- kGoodId, base::WrapUnique(new base::Version(kVersion123)),

+ kGoodId, base::MakeUnique<base::Version>(kVersion123),

kInvalidPathToCrx, Manifest::EXTERNAL_PREF, kCreationFlags,

kDontMarkAcknowledged, kDontInstallImmediately));

EXPECT_TRUE(service()->OnExternalExtensionFileFound(*info));

@@ -6019,7 +6019,7 @@ TEST_F(ExtensionServiceTest, ConcurrentExternalLocalFile) {

GURL kUpdateUrl("http://example.com/update");

std::unique_ptr<ExternalInstallInfoUpdateUrl> update_info(

new ExternalInstallInfoUpdateUrl(

- kGoodId, std::string(), base::WrapUnique(new GURL(kUpdateUrl)),

+ kGoodId, std::string(), base::MakeUnique<GURL>(kUpdateUrl),

Manifest::EXTERNAL_POLICY_DOWNLOAD, Extension::NO_FLAGS, false));

EXPECT_TRUE(service()->OnExternalExtensionUpdateUrlFound(*update_info, true));

EXPECT_TRUE((pending_info = pending->GetById(kGoodId)));