chrome/browser/extensions/extension_gcm_app_handler_unittest.cc - Issue 2257113002: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_gcm_app_handler_unittest.cc

Issue 2257113002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_garbage_collector_factory.cc ('k') | chrome/browser/extensions/extension_install_prompt.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_gcm_app_handler_unittest.cc

diff --git a/chrome/browser/extensions/extension_gcm_app_handler_unittest.cc b/chrome/browser/extensions/extension_gcm_app_handler_unittest.cc

index b515fac0095d1f4aadc5582d5cd2463ed319e73b..d972bc0bcd4092c96e6087a586a4f54fe8c73928 100644

--- a/chrome/browser/extensions/extension_gcm_app_handler_unittest.cc

+++ b/chrome/browser/extensions/extension_gcm_app_handler_unittest.cc

@@ -209,7 +209,7 @@ class ExtensionGCMAppHandlerTest : public testing::Test {

worker_pool->GetSequencedTaskRunnerWithShutdownBehavior(

worker_pool->GetSequenceToken(),

base::SequencedWorkerPool::SKIP_ON_SHUTDOWN));

- return base::WrapUnique(new gcm::GCMProfileService(

+ return base::MakeUnique<gcm::GCMProfileService>(

profile->GetPrefs(), profile->GetPath(), profile->GetRequestContext(),

chrome::GetChannel(),

gcm::GetProductCategoryForSubtypes(profile->GetPrefs()),

@@ -219,7 +219,7 @@ class ExtensionGCMAppHandlerTest : public testing::Test {

LoginUIServiceFactory::GetShowLoginPopupCallbackForProfile(

profile))),

base::WrapUnique(new gcm::FakeGCMClientFactory(ui_thread, io_thread)),

- ui_thread, io_thread, blocking_task_runner));

+ ui_thread, io_thread, blocking_task_runner);

}

ExtensionGCMAppHandlerTest()