chrome/browser/extensions/crx_installer.cc - Issue 2257113002: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/crx_installer.cc

Issue 2257113002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/chrome_extensions_browser_client.cc ('k') | chrome/browser/extensions/crx_installer_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/crx_installer.cc

diff --git a/chrome/browser/extensions/crx_installer.cc b/chrome/browser/extensions/crx_installer.cc

index 5859804ee13910d24764b5bfd98cc4cc61ee3186..2010fb26f681167169598dc10d74a0128a1e7b14 100644

--- a/chrome/browser/extensions/crx_installer.cc

+++ b/chrome/browser/extensions/crx_installer.cc

@@ -915,10 +915,10 @@ void CrxInstaller::ConfirmReEnable() {

ExtensionInstallPrompt::PromptType type =

ExtensionInstallPrompt::GetReEnablePromptTypeForExtension(

service->profile(), extension());

- client_->ShowDialog(

- base::Bind(&CrxInstaller::OnInstallPromptDone, this), extension(),

- nullptr, base::WrapUnique(new ExtensionInstallPrompt::Prompt(type)),

- ExtensionInstallPrompt::GetDefaultShowDialogCallback());

+ client_->ShowDialog(base::Bind(&CrxInstaller::OnInstallPromptDone, this),

+ extension(), nullptr,

+ base::MakeUnique<ExtensionInstallPrompt::Prompt>(type),

+ ExtensionInstallPrompt::GetDefaultShowDialogCallback());

}