chrome/browser/extensions/extension_action_runner.cc - Issue 2257113002: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_action_runner.cc

Issue 2257113002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/crx_installer_browsertest.cc ('k') | chrome/browser/extensions/extension_action_runner_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_action_runner.cc

diff --git a/chrome/browser/extensions/extension_action_runner.cc b/chrome/browser/extensions/extension_action_runner.cc

index 654129f1428077796fcd58edad6329cd269153cb..6230ed707a2d3baf58cd2d512c3a905b0bec6995 100644

--- a/chrome/browser/extensions/extension_action_runner.cc

+++ b/chrome/browser/extensions/extension_action_runner.cc

@@ -357,8 +357,9 @@ void ExtensionActionRunner::ShowBlockedActionBubble(

FROM_HERE,

base::Bind(callback, *default_bubble_close_action_for_testing_));

} else {

- toolbar_actions_bar->ShowToolbarActionBubble(base::WrapUnique(

- new BlockedActionBubbleDelegate(callback, extension->id())));

+ toolbar_actions_bar->ShowToolbarActionBubble(

+ base::MakeUnique<BlockedActionBubbleDelegate>(callback,

+ extension->id()));

}