Revert of Fix pylint warnings in webkitpy/common/.

Revert of Fix pylint warnings in webkitpy/common/. (patchset #4 id:60001 of https://codereview.chromium.org/2130093003/ )

Reason for revert:
Causing Linux ASAN bot failure:
crbug.com/637664

BUG=637664
Original issue's description:
> Fix pylint warnings in webkitpy/common/.
>
> Committed: https://crrev.com/741b54d9993d44d46435a759f6763cee9d5c07a5
> Cr-Commit-Position: refs/heads/master@{#411710}

TBR=dpranke@chromium.org,tansell@chromium.org,qyearsley@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.

Committed: https://crrev.com/df2bbdb19f72ca1cb73c189f9c6c657d6c8931ff
Cr-Commit-Position: refs/heads/master@{#411952}

[hiroshige, 2016-08-15 08:55:34]

The CQ bit was checked by hiroshige@chromium.org

[hiroshige, 2016-08-15 08:55:34]

Created Revert of Fix pylint warnings in webkitpy/common/.

[commit-bot: I haz the power, 2016-08-15 08:55:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 08:57:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 08:57:36]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[hiroshige, 2016-08-15 09:11:30]

The CQ bit was checked by hiroshige@chromium.org

[commit-bot: I haz the power, 2016-08-15 09:11:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 10:15:13]

Description was changed from

==========
Revert of Fix pylint warnings in webkitpy/common/. (patchset #4 id:60001 of
https://codereview.chromium.org/2130093003/ )

Reason for revert:
Causing Linux ASAN bot failure:
crbug.com/637664

BUG=637664


Original issue's description:
> Fix pylint warnings in webkitpy/common/.
> 
> Committed: https://crrev.com/741b54d9993d44d46435a759f6763cee9d5c07a5
> Cr-Commit-Position: refs/heads/master@{#411710}

TBR=dpranke@chromium.org,tansell@chromium.org,qyearsley@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
==========

to

==========
Revert of Fix pylint warnings in webkitpy/common/. (patchset #4 id:60001 of
https://codereview.chromium.org/2130093003/ )

Reason for revert:
Causing Linux ASAN bot failure:
crbug.com/637664

BUG=637664


Original issue's description:
> Fix pylint warnings in webkitpy/common/.
> 
> Committed: https://crrev.com/741b54d9993d44d46435a759f6763cee9d5c07a5
> Cr-Commit-Position: refs/heads/master@{#411710}

TBR=dpranke@chromium.org,tansell@chromium.org,qyearsley@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
==========

[commit-bot: I haz the power, 2016-08-15 10:15:14]

Committed patchset #2 (id:300001)

[commit-bot: I haz the power, 2016-08-15 10:17:18]

Description was changed from

==========
Revert of Fix pylint warnings in webkitpy/common/. (patchset #4 id:60001 of
https://codereview.chromium.org/2130093003/ )

Reason for revert:
Causing Linux ASAN bot failure:
crbug.com/637664

BUG=637664


Original issue's description:
> Fix pylint warnings in webkitpy/common/.
> 
> Committed: https://crrev.com/741b54d9993d44d46435a759f6763cee9d5c07a5
> Cr-Commit-Position: refs/heads/master@{#411710}

TBR=dpranke@chromium.org,tansell@chromium.org,qyearsley@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
==========

to

==========
Revert of Fix pylint warnings in webkitpy/common/. (patchset #4 id:60001 of
https://codereview.chromium.org/2130093003/ )

Reason for revert:
Causing Linux ASAN bot failure:
crbug.com/637664

BUG=637664

Original issue's description:
> Fix pylint warnings in webkitpy/common/.
>
> Committed: https://crrev.com/741b54d9993d44d46435a759f6763cee9d5c07a5
> Cr-Commit-Position: refs/heads/master@{#411710}

TBR=dpranke@chromium.org,tansell@chromium.org,qyearsley@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.

Committed: https://crrev.com/df2bbdb19f72ca1cb73c189f9c6c657d6c8931ff
Cr-Commit-Position: refs/heads/master@{#411952}
==========

[commit-bot: I haz the power, 2016-08-15 10:17:19]

Patchset 2 (id:??) landed as
https://crrev.com/df2bbdb19f72ca1cb73c189f9c6c657d6c8931ff
Cr-Commit-Position: refs/heads/master@{#411952}

[Dirk Pranke, 2016-08-15 19:58:58]

lgtm

[mithro, 2016-08-18 03:34:30]

On 2016/08/15 19:58:58, Dirk Pranke wrote:
> lgtm

Do we know why lint fixes broke only this bot?

[qyearsley, 2016-08-23 04:12:44]

On 2016/08/18 at 03:34:30, tansell wrote:
> On 2016/08/15 19:58:58, Dirk Pranke wrote:
> > lgtm
> 
> Do we know why lint fixes broke only this bot?

Good question.

The error was TypeError('run_command() got an unexpected keyword argument
'input'') --
run_command's keyword arguments were changed, and most callers were changed, but
anywhere
the function was called with the old keyword argument it would raise this error.

Looking at the stack trace, this happened inside of _get_crash_log
(https://cs.chromium.org/chromium/src/third_party/WebKit/Tools/Scripts/webkitp...)
and I guess when running layout tests that pass on regular bots, _get_crash_log
is not invoked, but this code path is executed when layout tests are run on ASAN
and MSAN bots.

Anyway, rather than re-landing this, I think any clean-up CLs I do should be
more focused and change one thing at a time, so that if something breaks it's
nicer to revert...