third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem_unittest.py - Issue 2248653002: Revert of Fix pylint warnings in webkitpy/common/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem_unittest.py

Issue 2248653002: Revert of Fix pylint warnings in webkitpy/common/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Manual Revert (Patch Set 1 causes patch failure in read_checksum_from_png_unittest.py) Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem_mock.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/common/system/logutils_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem_unittest.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem_unittest.py

index 8455a903f17981df8e3521140ed53bed258de3be..749562350ebd0878c7db2882776734c381ebff17 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem_unittest.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem_unittest.py

@@ -261,13 +261,13 @@ class RealFileSystemTest(unittest.TestCase, GenericFileSystemTests):

unicode_text_string = u'\u016An\u012Dc\u014Dde\u033D'

try:

text_path = tempfile.mktemp(prefix='tree_unittest_')

- out_file = fs.open_text_file_for_writing(text_path)

- out_file.write(unicode_text_string)

- out_file.close()

+ file = fs.open_text_file_for_writing(text_path)

+ file.write(unicode_text_string)

+ file.close()

- in_file = fs.open_text_file_for_reading(text_path)

- read_text = in_file.read()

- in_file.close()

+ file = fs.open_text_file_for_reading(text_path)

+ read_text = file.read()

+ file.close()

self.assertEqual(read_text, unicode_text_string)

finally:

@@ -312,7 +312,7 @@ class RealFileSystemTest(unittest.TestCase, GenericFileSystemTests):

RealFileSystemTest._remove_failures -= 1

if RealFileSystemTest._remove_failures >= 0:

try:

- raise WindowsError # pylint: disable=undefined-variable

+ raise WindowsError

except NameError:

raise FileSystem._WindowsError