third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive_mock.py - Issue 2248653002: Revert of Fix pylint warnings in webkitpy/common/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive_mock.py

Issue 2248653002: Revert of Fix pylint warnings in webkitpy/common/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Manual Revert (Patch Set 1 causes patch failure in read_checksum_from_png_unittest.py) Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive_mock.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive_mock.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive_mock.py

index c87ce688927356a29ba5f489f36d28901890aa2f..ea83b92d0649c976fa1da3fa99a38ee9db2787ea 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive_mock.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive_mock.py

@@ -94,7 +94,7 @@ class MockExecutive(object):

def run_command(self,

args,

cwd=None,

- input_func=None,

+ input=None,

error_handler=None,

return_exit_code=False,

return_stderr=True,

@@ -110,8 +110,8 @@ class MockExecutive(object):

if env:

env_string = ", env=%s" % env

input_string = ""

- if input_func:

- input_string = ", input=%s" % input_func

+ if input:

+ input_string = ", input=%s" % input

_log.info("MOCK run_command: %s, cwd=%s%s%s", args, cwd, env_string, input_string)

output = "MOCK output of child process"

@@ -190,7 +190,7 @@ class MockExecutive2(MockExecutive):