third_party/WebKit/Tools/Scripts/webkitpy/common/system/outputcapture.py - Issue 2248653002: Revert of Fix pylint warnings in webkitpy/common/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/system/outputcapture.py

Issue 2248653002: Revert of Fix pylint warnings in webkitpy/common/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Manual Revert (Patch Set 1 causes patch failure in read_checksum_from_png_unittest.py) Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/system/logutils_unittest.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/common/system/outputtee.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/common/system/outputcapture.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/system/outputcapture.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/system/outputcapture.py

index d6cfb72fab3ccebafddff04f8ddc3ae408643459..8511a7ea27dd0947f01dbe990aaddf7c2caa5650 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/system/outputcapture.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/system/outputcapture.py

@@ -79,10 +79,8 @@ class OutputCapture(object):

delattr(self, '_logs')

return (self._restore_output_with_name("stdout"), self._restore_output_with_name("stderr"), logs_string)

- def assert_outputs(self, testcase, function, args=None, kwargs=None, expected_stdout="",

+ def assert_outputs(self, testcase, function, args=[], kwargs={}, expected_stdout="",

expected_stderr="", expected_exception=None, expected_logs=None):

- args = args or []

- kwargs = kwargs or {}

self.capture_output()

try:

if expected_exception: