third_party/WebKit/Tools/Scripts/webkitpy/common/net/file_uploader.py - Issue 2248653002: Revert of Fix pylint warnings in webkitpy/common/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/net/file_uploader.py

Issue 2248653002: Revert of Fix pylint warnings in webkitpy/common/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Manual Revert (Patch Set 1 causes patch failure in read_checksum_from_png_unittest.py) Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/message_pool.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/common/net/networktransaction_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/common/net/file_uploader.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/file_uploader.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/file_uploader.py

index 7d20043de82cdb2adb081b20cf28e4bd8178f6a5..d12f78c360288122770a7ca81f4c8b2e2133d1ce 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/file_uploader.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/file_uploader.py

@@ -50,12 +50,12 @@ def _encode_multipart_form_data(fields, files):

Source:

http://code.google.com/p/rietveld/source/browse/trunk/upload.py

"""

- boundary = '-M-A-G-I-C---B-O-U-N-D-A-R-Y-'

+ BOUNDARY = '-M-A-G-I-C---B-O-U-N-D-A-R-Y-'

CRLF = '\r\n'

lines = []

for key, value in fields:

- lines.append('--' + boundary)

+ lines.append('--' + BOUNDARY)

lines.append('Content-Disposition: form-data; name="%s"' % key)

lines.append('')

if isinstance(value, unicode):

@@ -63,7 +63,7 @@ def _encode_multipart_form_data(fields, files):

lines.append(value)

for key, filename, value in files:

- lines.append('--' + boundary)

+ lines.append('--' + BOUNDARY)

lines.append('Content-Disposition: form-data; name="%s"; filename="%s"' % (key, filename))

lines.append('Content-Type: %s' % get_mime_type(filename))

lines.append('')

@@ -71,10 +71,10 @@ def _encode_multipart_form_data(fields, files):

value = value.encode('utf-8')

lines.append(value)

- lines.append('--' + boundary + '--')

+ lines.append('--' + BOUNDARY + '--')

lines.append('')

body = CRLF.join(lines)

- content_type = 'multipart/form-data; boundary=%s' % boundary

+ content_type = 'multipart/form-data; boundary=%s' % BOUNDARY

return content_type, body