Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/system/crashlogs_unittest.py

Issue 2248653002: Revert of Fix pylint warnings in webkitpy/common/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Manual Revert (Patch Set 1 causes patch failure in read_checksum_from_png_unittest.py) Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (C) 2011 Google Inc. All rights reserved. 1 # Copyright (C) 2011 Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions 4 # modification, are permitted provided that the following conditions
5 # are met: 5 # are met:
6 # 6 #
7 # 1. Redistributions of source code must retain the above copyright 7 # 1. Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # 2. Redistributions in binary form must reproduce the above copyright 9 # 2. Redistributions in binary form must reproduce the above copyright
10 # notice, this list of conditions and the following disclaimer in the 10 # notice, this list of conditions and the following disclaimer in the
(...skipping 11 matching lines...) Expand all
22 # THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 22 # THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
23 23
24 import unittest 24 import unittest
25 25
26 from webkitpy.common.system.crashlogs import CrashLogs 26 from webkitpy.common.system.crashlogs import CrashLogs
27 from webkitpy.common.system.filesystem_mock import MockFileSystem 27 from webkitpy.common.system.filesystem_mock import MockFileSystem
28 from webkitpy.common.system.systemhost import SystemHost 28 from webkitpy.common.system.systemhost import SystemHost
29 from webkitpy.common.system.systemhost_mock import MockSystemHost 29 from webkitpy.common.system.systemhost_mock import MockSystemHost
30 30
31 31
32 # pylint: disable=line-too-long
33 def make_mock_crash_report_darwin(process_name, pid): 32 def make_mock_crash_report_darwin(process_name, pid):
34 return """Process: {process_name} [{pid}] 33 return """Process: {process_name} [{pid}]
35 Path: /Volumes/Data/slave/snowleopard-intel-release-tests/build/WebKi tBuild/Release/{process_name} 34 Path: /Volumes/Data/slave/snowleopard-intel-release-tests/build/WebKi tBuild/Release/{process_name}
36 Identifier: {process_name} 35 Identifier: {process_name}
37 Version: ??? (???) 36 Version: ??? (???)
38 Code Type: X86-64 (Native) 37 Code Type: X86-64 (Native)
39 Parent Process: Python [2578] 38 Parent Process: Python [2578]
40 39
41 Date/Time: 2011-12-07 13:27:34.816 -0800 40 Date/Time: 2011-12-07 13:27:34.816 -0800
42 OS Version: Mac OS X 10.6.8 (10K549) 41 OS Version: Mac OS X 10.6.8 (10K549)
(...skipping 17 matching lines...) Expand all
60 0x7fff5fc00000 - 0x7fff5fc3be0f dyld 132.1 (???) <29DECB19-0193-2575-D8 38-CF743F0400B2> /usr/lib/dyld 59 0x7fff5fc00000 - 0x7fff5fc3be0f dyld 132.1 (???) <29DECB19-0193-2575-D8 38-CF743F0400B2> /usr/lib/dyld
61 60
62 System Profile: 61 System Profile:
63 Model: Xserve3,1, BootROM XS31.0081.B04, 8 processors, Quad-Core Intel Xeon, 2.2 6 GHz, 6 GB, SMC 1.43f4 62 Model: Xserve3,1, BootROM XS31.0081.B04, 8 processors, Quad-Core Intel Xeon, 2.2 6 GHz, 6 GB, SMC 1.43f4
64 Graphics: NVIDIA GeForce GT 120, NVIDIA GeForce GT 120, PCIe, 256 MB 63 Graphics: NVIDIA GeForce GT 120, NVIDIA GeForce GT 120, PCIe, 256 MB
65 Memory Module: global_name 64 Memory Module: global_name
66 Network Service: Ethernet 2, Ethernet, en1 65 Network Service: Ethernet 2, Ethernet, en1
67 PCI Card: NVIDIA GeForce GT 120, sppci_displaycontroller, MXM-Slot 66 PCI Card: NVIDIA GeForce GT 120, sppci_displaycontroller, MXM-Slot
68 Serial ATA Device: OPTIARC DVD RW AD-5670S 67 Serial ATA Device: OPTIARC DVD RW AD-5670S
69 """.format(process_name=process_name, pid=pid) 68 """.format(process_name=process_name, pid=pid)
70 # pylint: enable=line-too-long
71 69
72 70
73 class CrashLogsTest(unittest.TestCase): 71 class CrashLogsTest(unittest.TestCase):
74 72
75 def test_find_log_darwin(self): 73 def test_find_log_darwin(self):
76 if not SystemHost().platform.is_mac(): 74 if not SystemHost().platform.is_mac():
77 return 75 return
78 76
79 older_mock_crash_report = make_mock_crash_report_darwin('DumpRenderTree' , 28528) 77 older_mock_crash_report = make_mock_crash_report_darwin('DumpRenderTree' , 28528)
80 mock_crash_report = make_mock_crash_report_darwin('DumpRenderTree', 2853 0) 78 mock_crash_report = make_mock_crash_report_darwin('DumpRenderTree', 2853 0)
81 newer_mock_crash_report = make_mock_crash_report_darwin('DumpRenderTree' , 28529) 79 newer_mock_crash_report = make_mock_crash_report_darwin('DumpRenderTree' , 28529)
82 other_process_mock_crash_report = make_mock_crash_report_darwin('FooProc ess', 28527) 80 other_process_mock_crash_report = make_mock_crash_report_darwin('FooProc ess', 28527)
83 misformatted_mock_crash_report = 'Junk that should not appear in a crash report' + \ 81 misformatted_mock_crash_report = 'Junk that should not appear in a crash report' + \
84 make_mock_crash_report_darwin('DumpRenderTree', 28526)[200:] 82 make_mock_crash_report_darwin('DumpRenderTree', 28526)[200:]
85 files = {} 83 files = {}
86 # pylint: disable=line-too-long
87 files['/Users/mock/Library/Logs/DiagnosticReports/DumpRenderTree_2011-06 -13-150718_quadzen.crash'] = older_mock_crash_report 84 files['/Users/mock/Library/Logs/DiagnosticReports/DumpRenderTree_2011-06 -13-150718_quadzen.crash'] = older_mock_crash_report
88 files['/Users/mock/Library/Logs/DiagnosticReports/DumpRenderTree_2011-06 -13-150719_quadzen.crash'] = mock_crash_report 85 files['/Users/mock/Library/Logs/DiagnosticReports/DumpRenderTree_2011-06 -13-150719_quadzen.crash'] = mock_crash_report
89 files['/Users/mock/Library/Logs/DiagnosticReports/DumpRenderTree_2011-06 -13-150720_quadzen.crash'] = newer_mock_crash_report 86 files['/Users/mock/Library/Logs/DiagnosticReports/DumpRenderTree_2011-06 -13-150720_quadzen.crash'] = newer_mock_crash_report
90 files['/Users/mock/Library/Logs/DiagnosticReports/DumpRenderTree_2011-06 -13-150721_quadzen.crash'] = None 87 files['/Users/mock/Library/Logs/DiagnosticReports/DumpRenderTree_2011-06 -13-150721_quadzen.crash'] = None
91 files['/Users/mock/Library/Logs/DiagnosticReports/DumpRenderTree_2011-06 -13-150722_quadzen.crash'] = other_process_mock_crash_report 88 files['/Users/mock/Library/Logs/DiagnosticReports/DumpRenderTree_2011-06 -13-150722_quadzen.crash'] = other_process_mock_crash_report # noqa
92 files['/Users/mock/Library/Logs/DiagnosticReports/DumpRenderTree_2011-06 -13-150723_quadzen.crash'] = misformatted_mock_crash_report 89 files['/Users/mock/Library/Logs/DiagnosticReports/DumpRenderTree_2011-06 -13-150723_quadzen.crash'] = misformatted_mock_crash_report # noqa
93 # pylint: enable=line-too-long
94 filesystem = MockFileSystem(files) 90 filesystem = MockFileSystem(files)
95 crash_logs = CrashLogs(MockSystemHost(filesystem=filesystem)) 91 crash_logs = CrashLogs(MockSystemHost(filesystem=filesystem))
96 log = crash_logs.find_newest_log("DumpRenderTree") 92 log = crash_logs.find_newest_log("DumpRenderTree")
97 self.assertMultiLineEqual(log, newer_mock_crash_report) 93 self.assertMultiLineEqual(log, newer_mock_crash_report)
98 log = crash_logs.find_newest_log("DumpRenderTree", 28529) 94 log = crash_logs.find_newest_log("DumpRenderTree", 28529)
99 self.assertMultiLineEqual(log, newer_mock_crash_report) 95 self.assertMultiLineEqual(log, newer_mock_crash_report)
100 log = crash_logs.find_newest_log("DumpRenderTree", 28530) 96 log = crash_logs.find_newest_log("DumpRenderTree", 28530)
101 self.assertMultiLineEqual(log, mock_crash_report) 97 self.assertMultiLineEqual(log, mock_crash_report)
102 log = crash_logs.find_newest_log("DumpRenderTree", 28531) 98 log = crash_logs.find_newest_log("DumpRenderTree", 28531)
103 self.assertIsNone(log) 99 self.assertIsNone(log)
104 log = crash_logs.find_newest_log("DumpRenderTree", newer_than=1.0) 100 log = crash_logs.find_newest_log("DumpRenderTree", newer_than=1.0)
105 self.assertIsNone(log) 101 self.assertIsNone(log)
106 102
107 def bad_read(_): 103 def bad_read(path):
108 raise IOError('IOError: No such file or directory') 104 raise IOError('IOError: No such file or directory')
109 105
110 def bad_mtime(_): 106 def bad_mtime(path):
111 raise OSError('OSError: No such file or directory') 107 raise OSError('OSError: No such file or directory')
112 108
113 filesystem.read_text_file = bad_read 109 filesystem.read_text_file = bad_read
114 log = crash_logs.find_newest_log("DumpRenderTree", 28531, include_errors =True) 110 log = crash_logs.find_newest_log("DumpRenderTree", 28531, include_errors =True)
115 self.assertIn('IOError: No such file or directory', log) 111 self.assertIn('IOError: No such file or directory', log)
116 112
117 filesystem = MockFileSystem(files) 113 filesystem = MockFileSystem(files)
118 crash_logs = CrashLogs(MockSystemHost(filesystem=filesystem)) 114 crash_logs = CrashLogs(MockSystemHost(filesystem=filesystem))
119 filesystem.mtime = bad_mtime 115 filesystem.mtime = bad_mtime
120 log = crash_logs.find_newest_log("DumpRenderTree", newer_than=1.0, inclu de_errors=True) 116 log = crash_logs.find_newest_log("DumpRenderTree", newer_than=1.0, inclu de_errors=True)
121 self.assertIn('OSError: No such file or directory', log) 117 self.assertIn('OSError: No such file or directory', log)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698