Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/system/platforminfo.py

Issue 2248653002: Revert of Fix pylint warnings in webkitpy/common/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Manual Revert (Patch Set 1 causes patch failure in read_checksum_from_png_unittest.py) Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2011 Google Inc. All rights reserved. 1 # Copyright (c) 2011 Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following disclaimer 10 # copyright notice, this list of conditions and the following disclaimer
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
111 # automatically performs a line feed. 111 # automatically performs a line feed.
112 return right - left 112 return right - left
113 return sys.maxsize 113 return sys.maxsize
114 else: 114 else:
115 import fcntl 115 import fcntl
116 import struct 116 import struct
117 import termios 117 import termios
118 packed = fcntl.ioctl(sys.stderr.fileno(), termios.TIOCGWINSZ, '\ 0' * 8) 118 packed = fcntl.ioctl(sys.stderr.fileno(), termios.TIOCGWINSZ, '\ 0' * 8)
119 _, columns, _, _ = struct.unpack('HHHH', packed) 119 _, columns, _, _ = struct.unpack('HHHH', packed)
120 return columns 120 return columns
121 except Exception: # pylint: disable=broad-except 121 except:
122 return sys.maxsize 122 return sys.maxsize
123 123
124 def linux_distribution(self): 124 def linux_distribution(self):
125 if not self.is_linux(): 125 if not self.is_linux():
126 return None 126 return None
127 127
128 if self._filesystem.exists('/etc/redhat-release'): 128 if self._filesystem.exists('/etc/redhat-release'):
129 return 'redhat' 129 return 'redhat'
130 if self._filesystem.exists('/etc/debian_version'): 130 if self._filesystem.exists('/etc/debian_version'):
131 return 'debian' 131 return 'debian'
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
183 if hasattr(sys_module, 'getwindowsversion'): 183 if hasattr(sys_module, 'getwindowsversion'):
184 return sys_module.getwindowsversion() 184 return sys_module.getwindowsversion()
185 return self._win_version_tuple_from_cmd() 185 return self._win_version_tuple_from_cmd()
186 186
187 def _win_version_tuple_from_cmd(self): 187 def _win_version_tuple_from_cmd(self):
188 # Note that this should only ever be called on windows, so this should a lways work. 188 # Note that this should only ever be called on windows, so this should a lways work.
189 ver_output = self._executive.run_command(['cmd', '/c', 'ver'], decode_ou tput=False) 189 ver_output = self._executive.run_command(['cmd', '/c', 'ver'], decode_ou tput=False)
190 match_object = re.search(r'(?P<major>\d+)\.(?P<minor>\d)\.(?P<build>\d+) ', ver_output) 190 match_object = re.search(r'(?P<major>\d+)\.(?P<minor>\d)\.(?P<build>\d+) ', ver_output)
191 assert match_object, 'cmd returned an unexpected version string: ' + ver _output 191 assert match_object, 'cmd returned an unexpected version string: ' + ver _output
192 return tuple(map(int, match_object.groups())) 192 return tuple(map(int, match_object.groups()))
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698