third_party/WebKit/Tools/Scripts/webkitpy/common/system/platforminfo_unittest.py - Issue 2248653002: Revert of Fix pylint warnings in webkitpy/common/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/system/platforminfo_unittest.py

Issue 2248653002: Revert of Fix pylint warnings in webkitpy/common/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Manual Revert (Patch Set 1 causes patch failure in read_checksum_from_png_unittest.py) Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/system/platforminfo.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/common/system/stack_utils_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/common/system/platforminfo_unittest.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/system/platforminfo_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/system/platforminfo_unittest.py

index 592c007dbb7c5c1f16b3d1ef555e7c3b9f5c5f6e..4627afcd7c953d4ae57f8dbde6147b974f28f4ea 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/system/platforminfo_unittest.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/system/platforminfo_unittest.py

@@ -31,6 +31,7 @@ import sys

import unittest

from webkitpy.common.system.executive import Executive

+from webkitpy.common.system.executive_mock import MockExecutive

from webkitpy.common.system.executive_mock import MockExecutive2

from webkitpy.common.system.filesystem import FileSystem

from webkitpy.common.system.filesystem_mock import MockFileSystem

@@ -178,8 +179,8 @@ class TestPlatformInfo(unittest.TestCase):

self.assertEqual(self.make_info(fake_sys('cygwin'), executive=fake_executive('6.0.1234')).os_version, 'vista')

self.assertEqual(self.make_info(fake_sys('cygwin'), executive=fake_executive('5.1.1234')).os_version, 'xp')

- def _assert_file_implies_linux_distribution(self, filename, distribution):

- info = self.make_info(sys_module=fake_sys('linux2'), filesystem_module=MockFileSystem({filename: ''}))

+ def _assert_file_implies_linux_distribution(self, file, distribution):

+ info = self.make_info(sys_module=fake_sys('linux2'), filesystem_module=MockFileSystem({file: ''}))

self.assertEqual(info.linux_distribution(), distribution)

def test_linux_distro_detection(self):