third_party/WebKit/Tools/Scripts/webkitpy/common/find_files_unittest.py - Issue 2248653002: Revert of Fix pylint warnings in webkitpy/common/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/find_files_unittest.py

Issue 2248653002: Revert of Fix pylint warnings in webkitpy/common/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Manual Revert (Patch Set 1 causes patch failure in read_checksum_from_png_unittest.py) Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/find_files.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/common/memoized.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/common/find_files_unittest.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/find_files_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/find_files_unittest.py

index 85dfa71b864431497f07655d86bfee76acb5ca46..665b45562714a8058188db14fcdd271d8d32dfe3 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/find_files_unittest.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/find_files_unittest.py

@@ -29,8 +29,8 @@

import sys

import unittest

-from webkitpy.common import find_files

from webkitpy.common.system.filesystem import FileSystem

+import find_files

class MockWinFileSystem(object):

@@ -45,10 +45,9 @@ class MockWinFileSystem(object):

class TestWinNormalize(unittest.TestCase):

def assert_filesystem_normalizes(self, filesystem):

- self.assertEqual(

- find_files.normalize(filesystem, "c:\\foo",

- ['fast/html', 'fast/canvas/*', 'compositing/foo.html']),

- ['c:\\foo\\fast\\html', 'c:\\foo\\fast\\canvas\\*', 'c:\\foo\\compositing\\foo.html'])

+ self.assertEqual(find_files._normalize(filesystem, "c:\\foo",

+ ['fast/html', 'fast/canvas/*', 'compositing/foo.html']),

+ ['c:\\foo\\fast\html', 'c:\\foo\\fast\canvas\*', 'c:\\foo\compositing\\foo.html'])

def test_mocked_win(self):

# This tests test_files.normalize, using portable behavior emulating