Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2058)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/message_pool.py

Issue 2248653002: Revert of Fix pylint warnings in webkitpy/common/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Manual Revert (Patch Set 1 causes patch failure in read_checksum_from_png_unittest.py) Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/common/message_pool.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/message_pool.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/message_pool.py
index db2d830fa64ae7adc2ed8a5f37ddb95d30679b17..ab1f1a0b1575bba22b0d9a8e65c2eff4bbd6beae 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/message_pool.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/message_pool.py
@@ -37,6 +37,7 @@ and concurrency.futures.ProcessPoolExecutor, with the following differences:
If you don't need these features, use multiprocessing.Pool or concurrency.futures
instead.
+
"""
import cPickle
@@ -310,8 +311,8 @@ class _Worker(multiprocessing.Process):
# The unix multiprocessing implementation clones any log handlers into the child process,
# so we remove them to avoid duplicate logging.
- for handler in self._logger.handlers:
- self._logger.removeHandler(handler)
+ for h in self._logger.handlers:
+ self._logger.removeHandler(h)
self._log_handler = _WorkerLogHandler(self)
self._logger.addHandler(self._log_handler)

Powered by Google App Engine
This is Rietveld 408576698