Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/find_files_unittest.py

Issue 2248653002: Revert of Fix pylint warnings in webkitpy/common/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Manual Revert (Patch Set 1 causes patch failure in read_checksum_from_png_unittest.py) Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (C) 2011 Google Inc. All rights reserved. 1 # Copyright (C) 2011 Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following disclaimer 10 # copyright notice, this list of conditions and the following disclaimer
(...skipping 11 matching lines...) Expand all
22 # SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 22 # SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
23 # LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 23 # LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
24 # DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 24 # DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
25 # THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 25 # THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
26 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 26 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
27 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 27 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
28 28
29 import sys 29 import sys
30 import unittest 30 import unittest
31 31
32 from webkitpy.common import find_files
33 from webkitpy.common.system.filesystem import FileSystem 32 from webkitpy.common.system.filesystem import FileSystem
33 import find_files
34 34
35 35
36 class MockWinFileSystem(object): 36 class MockWinFileSystem(object):
37 37
38 def join(self, *paths): 38 def join(self, *paths):
39 return '\\'.join(paths) 39 return '\\'.join(paths)
40 40
41 def normpath(self, path): 41 def normpath(self, path):
42 return path.replace('/', '\\') 42 return path.replace('/', '\\')
43 43
44 44
45 class TestWinNormalize(unittest.TestCase): 45 class TestWinNormalize(unittest.TestCase):
46 46
47 def assert_filesystem_normalizes(self, filesystem): 47 def assert_filesystem_normalizes(self, filesystem):
48 self.assertEqual( 48 self.assertEqual(find_files._normalize(filesystem, "c:\\foo",
49 find_files.normalize(filesystem, "c:\\foo", 49 ['fast/html', 'fast/canvas/*', 'c ompositing/foo.html']),
50 ['fast/html', 'fast/canvas/*', 'compositing/foo .html']), 50 ['c:\\foo\\fast\html', 'c:\\foo\\fast\canvas\*', 'c:\\f oo\compositing\\foo.html'])
51 ['c:\\foo\\fast\\html', 'c:\\foo\\fast\\canvas\\*', 'c:\\foo\\compos iting\\foo.html'])
52 51
53 def test_mocked_win(self): 52 def test_mocked_win(self):
54 # This tests test_files.normalize, using portable behavior emulating 53 # This tests test_files.normalize, using portable behavior emulating
55 # what we think Windows is supposed to do. This test will run on all 54 # what we think Windows is supposed to do. This test will run on all
56 # platforms. 55 # platforms.
57 self.assert_filesystem_normalizes(MockWinFileSystem()) 56 self.assert_filesystem_normalizes(MockWinFileSystem())
58 57
59 def test_win(self): 58 def test_win(self):
60 # This tests the actual windows platform, to ensure we get the same 59 # This tests the actual windows platform, to ensure we get the same
61 # results that we get in test_mocked_win(). 60 # results that we get in test_mocked_win().
62 if sys.platform != 'win32': 61 if sys.platform != 'win32':
63 return 62 return
64 self.assert_filesystem_normalizes(FileSystem()) 63 self.assert_filesystem_normalizes(FileSystem())
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698