third_party/WebKit/Tools/Scripts/webkitpy/common/prettypatch.py - Issue 2248653002: Revert of Fix pylint warnings in webkitpy/common/.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/prettypatch.py

Issue 2248653002: Revert of Fix pylint warnings in webkitpy/common/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Manual Revert (Patch Set 1 causes patch failure in read_checksum_from_png_unittest.py) Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/common/read_checksum_from_png_unittest.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright (c) 2010 Google Inc. All rights reserved.	1 # Copyright (c) 2010 Google Inc. All rights reserved.

2 #	2 #

3 # Redistribution and use in source and binary forms, with or without	3 # Redistribution and use in source and binary forms, with or without

4 # modification, are permitted provided that the following conditions are	4 # modification, are permitted provided that the following conditions are

5 # met:	5 # met:

6 #	6 #

7 # * Redistributions of source code must retain the above copyright	7 # * Redistributions of source code must retain the above copyright

8 # notice, this list of conditions and the following disclaimer.	8 # notice, this list of conditions and the following disclaimer.

9 # * Redistributions in binary form must reproduce the above	9 # * Redistributions in binary form must reproduce the above

10 # copyright notice, this list of conditions and the following disclaimer	10 # copyright notice, this list of conditions and the following disclaimer

(...skipping 44 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
55 'webkitruby', 'PrettyPatch')	55 'webkitruby', 'PrettyPatch')

56 prettify_path = os.path.join(pretty_patch_path, "prettify.rb")	56 prettify_path = os.path.join(pretty_patch_path, "prettify.rb")

57 args = [	57 args = [

58 "ruby",	58 "ruby",

59 "-I",	59 "-I",

60 pretty_patch_path,	60 pretty_patch_path,

61 prettify_path,	61 prettify_path,

62 ]	62 ]

63 # PrettyPatch does not modify the encoding of the diff output	63 # PrettyPatch does not modify the encoding of the diff output

64 # so we can't expect it to be utf-8.	64 # so we can't expect it to be utf-8.

65 return self._executive.run_command(args, input_func=diff, decode_output= False)	65 return self._executive.run_command(args, input=diff, decode_output=False )

OLD	NEW