third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld.py - Issue 2248653002: Revert of Fix pylint warnings in webkitpy/common/.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld.py

Issue 2248653002: Revert of Fix pylint warnings in webkitpy/common/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Manual Revert (Patch Set 1 causes patch failure in read_checksum_from_png_unittest.py) Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/net/networktransaction_unittest.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/common/prettypatch.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright 2016 The Chromium Authors. All rights reserved.	1 # Copyright 2016 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 """Utility functions to communicate with Rietveld."""	5 """Utility functions to communicate with Rietveld."""

6	6

	7 import collections

7 import json	8 import json

8 import logging	9 import logging

9 import urllib2	10 import urllib2

10	11

11 from webkitpy.common.net.buildbot import Build	12 from webkitpy.common.net.buildbot import Build

12	13

13	14

14 _log = logging.getLogger(__name__)	15 _log = logging.getLogger(__name__)

15	16

16 BASE_CODEREVIEW_URL = 'https://codereview.chromium.org/api'	17 BASE_CODEREVIEW_URL = 'https://codereview.chromium.org/api'

(...skipping 98 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
115 )]	116 )]

116	117

117	118

118 def get_latest_try_job_results(issue_number, web):	119 def get_latest_try_job_results(issue_number, web):

119 url = _latest_patchset_url(issue_number, web)	120 url = _latest_patchset_url(issue_number, web)

120 patchset_data = _get_json(url, web)	121 patchset_data = _get_json(url, web)

121 results = {}	122 results = {}

122 for job in patchset_data['try_job_results']:	123 for job in patchset_data['try_job_results']:

123 results[job['builder']] = job['result']	124 results[job['builder']] = job['result']

124 return results	125 return results

OLD	NEW