Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/system/platforminfo_unittest.py

Issue 2248653002: Revert of Fix pylint warnings in webkitpy/common/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Manual Revert (Patch Set 1 causes patch failure in read_checksum_from_png_unittest.py) Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (C) 2011 Google Inc. All rights reserved. 1 # Copyright (C) 2011 Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following disclaimer 10 # copyright notice, this list of conditions and the following disclaimer
(...skipping 13 matching lines...) Expand all
24 # DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 24 # DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
25 # THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 25 # THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
26 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 26 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
27 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 27 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
28 28
29 import platform 29 import platform
30 import sys 30 import sys
31 import unittest 31 import unittest
32 32
33 from webkitpy.common.system.executive import Executive 33 from webkitpy.common.system.executive import Executive
34 from webkitpy.common.system.executive_mock import MockExecutive
34 from webkitpy.common.system.executive_mock import MockExecutive2 35 from webkitpy.common.system.executive_mock import MockExecutive2
35 from webkitpy.common.system.filesystem import FileSystem 36 from webkitpy.common.system.filesystem import FileSystem
36 from webkitpy.common.system.filesystem_mock import MockFileSystem 37 from webkitpy.common.system.filesystem_mock import MockFileSystem
37 from webkitpy.common.system.platforminfo import PlatformInfo 38 from webkitpy.common.system.platforminfo import PlatformInfo
38 39
39 40
40 def fake_sys(platform_str='darwin', windows_version_tuple=None): 41 def fake_sys(platform_str='darwin', windows_version_tuple=None):
41 42
42 class FakeSysModule(object): 43 class FakeSysModule(object):
43 platform = platform_str 44 platform = platform_str
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
171 executive=fake_executive('6.1.1234')) 172 executive=fake_executive('6.1.1234'))
172 self.assertEqual(self.make_info(fake_sys('cygwin'), executive=fake_execu tive('10.1.1234')).os_version, 'future') 173 self.assertEqual(self.make_info(fake_sys('cygwin'), executive=fake_execu tive('10.1.1234')).os_version, 'future')
173 self.assertEqual(self.make_info(fake_sys('cygwin'), executive=fake_execu tive('10.0.1234')).os_version, '10') 174 self.assertEqual(self.make_info(fake_sys('cygwin'), executive=fake_execu tive('10.0.1234')).os_version, '10')
174 self.assertEqual(self.make_info(fake_sys('cygwin'), executive=fake_execu tive('6.3.1234')).os_version, '8.1') 175 self.assertEqual(self.make_info(fake_sys('cygwin'), executive=fake_execu tive('6.3.1234')).os_version, '8.1')
175 self.assertEqual(self.make_info(fake_sys('cygwin'), executive=fake_execu tive('6.2.1234')).os_version, '8') 176 self.assertEqual(self.make_info(fake_sys('cygwin'), executive=fake_execu tive('6.2.1234')).os_version, '8')
176 self.assertEqual(self.make_info(fake_sys('cygwin'), executive=fake_execu tive('6.1.7601')).os_version, '7sp1') 177 self.assertEqual(self.make_info(fake_sys('cygwin'), executive=fake_execu tive('6.1.7601')).os_version, '7sp1')
177 self.assertEqual(self.make_info(fake_sys('cygwin'), executive=fake_execu tive('6.1.7600')).os_version, '7sp0') 178 self.assertEqual(self.make_info(fake_sys('cygwin'), executive=fake_execu tive('6.1.7600')).os_version, '7sp0')
178 self.assertEqual(self.make_info(fake_sys('cygwin'), executive=fake_execu tive('6.0.1234')).os_version, 'vista') 179 self.assertEqual(self.make_info(fake_sys('cygwin'), executive=fake_execu tive('6.0.1234')).os_version, 'vista')
179 self.assertEqual(self.make_info(fake_sys('cygwin'), executive=fake_execu tive('5.1.1234')).os_version, 'xp') 180 self.assertEqual(self.make_info(fake_sys('cygwin'), executive=fake_execu tive('5.1.1234')).os_version, 'xp')
180 181
181 def _assert_file_implies_linux_distribution(self, filename, distribution): 182 def _assert_file_implies_linux_distribution(self, file, distribution):
182 info = self.make_info(sys_module=fake_sys('linux2'), filesystem_module=M ockFileSystem({filename: ''})) 183 info = self.make_info(sys_module=fake_sys('linux2'), filesystem_module=M ockFileSystem({file: ''}))
183 self.assertEqual(info.linux_distribution(), distribution) 184 self.assertEqual(info.linux_distribution(), distribution)
184 185
185 def test_linux_distro_detection(self): 186 def test_linux_distro_detection(self):
186 self._assert_file_implies_linux_distribution('/etc/arch-release', 'arch' ) 187 self._assert_file_implies_linux_distribution('/etc/arch-release', 'arch' )
187 self._assert_file_implies_linux_distribution('/etc/debian_version', 'deb ian') 188 self._assert_file_implies_linux_distribution('/etc/debian_version', 'deb ian')
188 self._assert_file_implies_linux_distribution('/etc/redhat-release', 'red hat') 189 self._assert_file_implies_linux_distribution('/etc/redhat-release', 'red hat')
189 self._assert_file_implies_linux_distribution('/etc/mock-release', 'unkno wn') 190 self._assert_file_implies_linux_distribution('/etc/mock-release', 'unkno wn')
190 191
191 info = self.make_info(fake_sys('cygwin'), executive=fake_executive('6.1. 7600')) 192 info = self.make_info(fake_sys('cygwin'), executive=fake_executive('6.1. 7600'))
192 self.assertIsNone(info.linux_distribution()) 193 self.assertIsNone(info.linux_distribution())
(...skipping 16 matching lines...) Expand all
209 self.assertEqual(info.total_bytes_memory(), 1234) 210 self.assertEqual(info.total_bytes_memory(), 1234)
210 211
211 info = self.make_info(fake_sys('win32', tuple([6, 1, 7600]))) 212 info = self.make_info(fake_sys('win32', tuple([6, 1, 7600])))
212 self.assertIsNone(info.total_bytes_memory()) 213 self.assertIsNone(info.total_bytes_memory())
213 214
214 info = self.make_info(fake_sys('linux2')) 215 info = self.make_info(fake_sys('linux2'))
215 self.assertIsNone(info.total_bytes_memory()) 216 self.assertIsNone(info.total_bytes_memory())
216 217
217 info = self.make_info(fake_sys('freebsd9')) 218 info = self.make_info(fake_sys('freebsd9'))
218 self.assertIsNone(info.total_bytes_memory()) 219 self.assertIsNone(info.total_bytes_memory())
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698