third_party/WebKit/Tools/Scripts/webkitpy/common/net/networktransaction_unittest.py - Issue 2248653002: Revert of Fix pylint warnings in webkitpy/common/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/net/networktransaction_unittest.py

Issue 2248653002: Revert of Fix pylint warnings in webkitpy/common/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Manual Revert (Patch Set 1 causes patch failure in read_checksum_from_png_unittest.py) Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/net/file_uploader.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/common/net/networktransaction_unittest.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/networktransaction_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/networktransaction_unittest.py

index fbc4f17ae911e1aa76e6f78f7797c33e8eb8751b..8b696eeca2385e1381cf5e02fadb727791f42721 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/networktransaction_unittest.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/networktransaction_unittest.py

@@ -53,7 +53,7 @@ class NetworkTransactionTest(LoggingTestCase):

try:

transaction.run(self._raise_exception)

did_throw_exception = False

- except Exception as e: # pylint: disable=broad-except

+ except Exception as e:

did_process_exception = True

self.assertEqual(e, self.exception)

self.assertTrue(did_throw_exception)

@@ -77,7 +77,7 @@ class NetworkTransactionTest(LoggingTestCase):

'WARNING: Received HTTP status 500 loading "http://example.com/". '

'Retrying in 0.0 seconds...\n'])

- def test_convert_404_to_none(self):

+ def test_convert_404_to_None(self):

transaction = NetworkTransaction(convert_404_to_None=True)

self.assertIsNone(transaction.run(self._raise_404_error))