Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1328)

Issue 2059913002: Remove keyIdentifier usage in chrome/browser/resources/* (Closed)

Created:
4 years, 6 months ago by dtapuska
Modified:
4 years, 6 months ago
Reviewers:
dmazzoni, Dan Beam
CC:
chromium-reviews, asanka, dbeam+watch-options_chromium.org, yusukes+watch_chromium.org, shuchen+watch_chromium.org, noyau+watch_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org, aboxhall+watch_chromium.org, dzhioev+watch_chromium.org, achuith+watch_chromium.org, Patrick Dubroy, nona+watch_chromium.org, je_julie, chromium-apps-reviews_chromium.org, pedrosimonetti+watch_chromium.org, dbeam+watch-ntp_chromium.org, yuzo+watch_chromium.org, michaelpg+watch-md-ui_chromium.org, pam+watch_chromium.org, oshima+watch_chromium.org, dbeam+watch-downloads_chromium.org, michaelpg+watch-options_chromium.org, tfarina, nektar+watch_chromium.org, dbeam+watch-history_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove keyIdentifier usage in chrome/browser/resources/* This removes the majority of the keyIdentifier usages in the browser resources. Replace the usage with the formally specified 'key' field. No functional changes intended. BUG=607349 NOPRESUBMIT=true CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/bb476ec391db39b6334519844e555c0711cd02d1 Cr-Commit-Position: refs/heads/master@{#399913}

Patch Set 1 #

Patch Set 2 : Remove a few tests that were failing because webui hasn't changed yet #

Total comments: 1

Patch Set 3 : Fix chromeos build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -88 lines) Patch
M chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/i_search.js View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js View 1 2 1 chunk +8 lines, -8 lines 0 comments Download
M chrome/browser/resources/chromeos/keyboard/keyboard_utils.js View 2 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/resources/chromeos/login/screen_supervised_user_creation.js View 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/resources/chromeos/sim_unlock.js View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/resources/chromeos/user_images_grid.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_images_grid.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/extensions/chromeos/kiosk_apps.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/extensions/extension_error.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/history/history.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/hotword_audio_verification/main.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/inspect/inspect.js View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/md_downloads/crisper.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/ntp4/apps_page.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/ntp4/dot_list.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/ntp4/nav_dot.js View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/ntp4/page_list_view.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/ntp4/tile_page.js View 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/browser/resources/options/chromeos/accounts_user_name_edit.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/chromeos/network_list.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/cookies_list.js View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/options/cookies_view.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/editable_text_field.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/home_page_overlay.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/inline_editable_list.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/language_dictionary_overlay.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/language_options.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/sync_confirmation/sync_confirmation.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_browsertest.js View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/accounts_options_browsertest.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/cookies_view_browsertest.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/edit_dictionary_browsertest.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/keyevents_test.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/webui/link_controller_test.html View 6 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
dtapuska
4 years, 6 months ago (2016-06-10 19:56:06 UTC) #4
dmazzoni
lgtm for chromevox
4 years, 6 months ago (2016-06-10 20:33:26 UTC) #6
Dan Beam
lgtm maybe check out ui/webui/resources next? ;) and thanks for this! https://codereview.chromium.org/2059913002/diff/20001/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js File chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js (right): ...
4 years, 6 months ago (2016-06-14 00:20:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2059913002/40001
4 years, 6 months ago (2016-06-15 14:47:12 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-15 16:14:31 UTC) #13
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-15 16:14:46 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 16:16:28 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/bb476ec391db39b6334519844e555c0711cd02d1
Cr-Commit-Position: refs/heads/master@{#399913}

Powered by Google App Engine
This is Rietveld 408576698