Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3192)

Unified Diff: chrome/browser/resources/chromeos/sim_unlock.js

Issue 2059913002: Remove keyIdentifier usage in chrome/browser/resources/* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix chromeos build Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/sim_unlock.js
diff --git a/chrome/browser/resources/chromeos/sim_unlock.js b/chrome/browser/resources/chromeos/sim_unlock.js
index 64aedb0d5470fb7ec38e86b47b12859226322e67..29c0fa2aed8cc33a43b41750dace3511cc7e1100 100644
--- a/chrome/browser/resources/chromeos/sim_unlock.js
+++ b/chrome/browser/resources/chromeos/sim_unlock.js
@@ -229,7 +229,7 @@ cr.define('mobile', function() {
// PIN input screen.
$('pin-input').addEventListener('keydown', function(event) {
- if (event.keyIdentifier == 'Enter') {
+ if (event.key == 'Enter') {
SimUnlock.submitPin();
return;
}
@@ -258,7 +258,7 @@ cr.define('mobile', function() {
// PUK input screen.
$('puk-input').addEventListener('keydown', function(event) {
- if (event.keyIdentifier == 'Enter') {
+ if (event.key == 'Enter') {
SimUnlock.pukEntered($('puk-input').value);
return;
}
@@ -279,7 +279,7 @@ cr.define('mobile', function() {
// Change PIN / new PIN screen.
$('old-pin-input').addEventListener('keydown', function(event) {
- if (event.keyIdentifier == 'Enter') {
+ if (event.key == 'Enter') {
if (this.value.length >= SimUnlock.PIN_MIN_LENGTH)
$('new-pin-input').focus();
return;
@@ -295,7 +295,7 @@ cr.define('mobile', function() {
$('old-pin-input').addEventListener('textInput',
SimUnlock.processInput.bind(this));
$('new-pin-input').addEventListener('keydown', function(event) {
- if (event.keyIdentifier == 'Enter') {
+ if (event.key == 'Enter') {
if (this.value.length >= SimUnlock.PIN_MIN_LENGTH)
$('retype-new-pin-input').focus();
return;
@@ -328,7 +328,7 @@ cr.define('mobile', function() {
!oldPinOk;
});
$('retype-new-pin-input').addEventListener('keydown', function(event) {
- if (event.keyIdentifier == 'Enter') {
+ if (event.key == 'Enter') {
SimUnlock.newPinEntered($('new-pin-input').value,
$('retype-new-pin-input').value);
return;

Powered by Google App Engine
This is Rietveld 408576698