chrome/browser/resources/ntp4/page_list_view.js - Issue 2059913002: Remove keyIdentifier usage in chrome/browser/resources/*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/ntp4/page_list_view.js

Issue 2059913002: Remove keyIdentifier usage in chrome/browser/resources/* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix chromeos build Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/ntp4/page_list_view.js

diff --git a/chrome/browser/resources/ntp4/page_list_view.js b/chrome/browser/resources/ntp4/page_list_view.js

index 08417cd28b3006cdbca0bb5bfd5a00096b781eac..6ec7d4e79cf05c53578a0bada333819206ab46ab 100644

--- a/chrome/browser/resources/ntp4/page_list_view.js

+++ b/chrome/browser/resources/ntp4/page_list_view.js

@@ -732,9 +732,9 @@ cr.define('ntp', function() {

return;

var direction = 0;

- if (e.keyIdentifier == 'Left')

+ if (e.key == 'ArrowLeft')

direction = -1;

- else if (e.keyIdentifier == 'Right')

+ else if (e.key == 'ArrowRight')

direction = 1;

else

return;

« no previous file with comments | « chrome/browser/resources/ntp4/nav_dot.js ('k') | chrome/browser/resources/ntp4/tile_page.js » ('j') | no next file with comments »