chrome/browser/resources/chromeos/chromevox/cvox2/background/i_search.js - Issue 2059913002: Remove keyIdentifier usage in chrome/browser/resources/*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/i_search.js

Issue 2059913002: Remove keyIdentifier usage in chrome/browser/resources/* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix chromeos build Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js ('k') | chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/i_search.js

diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/i_search.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/i_search.js

index b2194202230c8b334f0fe5d4d936f3afcb9f43c8..1ccffac9f7f98517f013a8338a82fd9e409981b5 100644

--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/i_search.js

+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/i_search.js

@@ -147,14 +147,14 @@ ISearchUI.prototype = {

* @return {boolean}

onKeyDown: function(evt) {

- switch (evt.keyIdentifier) {

- case 'Up':

+ switch (evt.key) {

+ case 'ArrowUp':

this.dir_ = Dir.BACKWARD;

break;

- case 'Down':

+ case 'ArrowDown':

this.dir_ = Dir.FORWARD;

break;

- case 'U+001B': // Escape

+ case 'Escape':

this.pendingSearchId_ = 0;

this.background_['endExcursion']();

Panel.closeMenusAndRestoreFocus();