chrome/browser/resources/options/language_dictionary_overlay.js - Issue 2059913002: Remove keyIdentifier usage in chrome/browser/resources/*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/language_dictionary_overlay.js

Issue 2059913002: Remove keyIdentifier usage in chrome/browser/resources/* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix chromeos build Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/options/inline_editable_list.js ('k') | chrome/browser/resources/options/language_options.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/language_dictionary_overlay.js

diff --git a/chrome/browser/resources/options/language_dictionary_overlay.js b/chrome/browser/resources/options/language_dictionary_overlay.js

index 61e351afa662938907dbde59da3fd3d44355a16d..6f7a4a2ccb8f0fbad25d18cc50e56711cdf71e45 100644

--- a/chrome/browser/resources/options/language_dictionary_overlay.js

+++ b/chrome/browser/resources/options/language_dictionary_overlay.js

@@ -63,7 +63,7 @@ cr.define('options', function() {

this.searchField_.onkeydown = function(e) {

// Don't propagate enter key events. Otherwise the default button will

// activate.

- if (e.keyIdentifier == 'Enter')

+ if (e.key == 'Enter')

e.stopPropagation();

};

« no previous file with comments | « chrome/browser/resources/options/inline_editable_list.js ('k') | chrome/browser/resources/options/language_options.js » ('j') | no next file with comments »