Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Unified Diff: chrome/browser/resources/chromeos/keyboard/keyboard_utils.js

Issue 2059913002: Remove keyIdentifier usage in chrome/browser/resources/* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix chromeos build Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/keyboard/keyboard_utils.js
diff --git a/chrome/browser/resources/chromeos/keyboard/keyboard_utils.js b/chrome/browser/resources/chromeos/keyboard/keyboard_utils.js
index 6a520ec17562d5cd9199acb38982e16da98ea606..3ec46a814e37bbcf310711550fd3c11c2bf96a6a 100644
--- a/chrome/browser/resources/chromeos/keyboard/keyboard_utils.js
+++ b/chrome/browser/resources/chromeos/keyboard/keyboard_utils.js
@@ -18,10 +18,10 @@ keyboard.onKeyIgnore_ = function(event) {
if (event.ctrlKey || event.shiftKey || event.altKey || event.metaKey)
return;
- if (event.keyIdentifier == 'Left' ||
- event.keyIdentifier == 'Right' ||
- event.keyIdentifier == 'Up' ||
- event.keyIdentifier == 'Down') {
+ if (event.key == 'ArrowLeft' ||
+ event.key == 'ArrowRight' ||
+ event.key == 'ArrowUp' ||
+ event.key == 'ArrowDown') {
event.stopPropagation();
event.preventDefault();
}
@@ -53,13 +53,13 @@ keyboard.onKeyDown_ = function(event) {
var needsUpDownKeys = event.target.classList.contains('needs-up-down-keys');
- if (event.keyIdentifier == 'Left' ||
- (!needsUpDownKeys && event.keyIdentifier == 'Up')) {
+ if (event.key == 'ArrowLeft' ||
+ (!needsUpDownKeys && event.key == 'ArrowUp')) {
keyboard.raiseKeyFocusPrevious(document.activeElement);
event.stopPropagation();
event.preventDefault();
- } else if (event.keyIdentifier == 'Right' ||
- (!needsUpDownKeys && event.keyIdentifier == 'Down')) {
+ } else if (event.key == 'ArrowRight' ||
+ (!needsUpDownKeys && event.key == 'ArrowDown')) {
keyboard.raiseKeyFocusNext(document.activeElement);
event.stopPropagation();
event.preventDefault();

Powered by Google App Engine
This is Rietveld 408576698