chrome/browser/resources/options/home_page_overlay.js - Issue 2059913002: Remove keyIdentifier usage in chrome/browser/resources/*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/home_page_overlay.js

Issue 2059913002: Remove keyIdentifier usage in chrome/browser/resources/* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix chromeos build Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/options/editable_text_field.js ('k') | chrome/browser/resources/options/inline_editable_list.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/home_page_overlay.js

diff --git a/chrome/browser/resources/options/home_page_overlay.js b/chrome/browser/resources/options/home_page_overlay.js

index 4829d085ebb0f83cb5d0b11c48b1c09d6b8c6ee5..550379714e10fc254a1660c2d9edce71dff57ca6 100644

--- a/chrome/browser/resources/options/home_page_overlay.js

+++ b/chrome/browser/resources/options/home_page_overlay.js

@@ -45,7 +45,7 @@ cr.define('options', function() {

urlField.addEventListener('keydown', function(event) {

// Don't auto-submit when the user selects something from the

// auto-complete list.

- if (event.keyIdentifier == 'Enter' && !self.autocompleteList_.hidden)

+ if (event.key == 'Enter' && !self.autocompleteList_.hidden)

event.stopPropagation();

});

urlField.addEventListener('change', this.updateFavicon_.bind(this));