chrome/browser/resources/options/editable_text_field.js - Issue 2059913002: Remove keyIdentifier usage in chrome/browser/resources/*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/editable_text_field.js

Issue 2059913002: Remove keyIdentifier usage in chrome/browser/resources/* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix chromeos build Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/options/editable_text_field.js

diff --git a/chrome/browser/resources/options/editable_text_field.js b/chrome/browser/resources/options/editable_text_field.js

index 9c04b62da7cafc6c6a431326e4137f6f9d44f0b6..b895613007ea11c3690faef530b596dd528dc297 100644

--- a/chrome/browser/resources/options/editable_text_field.js

+++ b/chrome/browser/resources/options/editable_text_field.js

@@ -333,8 +333,8 @@ cr.define('options', function() {

return;

var endEdit;

- switch (e.keyIdentifier) {

- case 'U+001B': // Esc

+ switch (e.key) {

+ case 'Escape':

this.editCanceled_ = true;

endEdit = true;

break;

« no previous file with comments | « chrome/browser/resources/options/cookies_view.js ('k') | chrome/browser/resources/options/home_page_overlay.js » ('j') | no next file with comments »