Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6143)

Unified Diff: chrome/browser/resources/chromeos/login/screen_supervised_user_creation.js

Issue 2059913002: Remove keyIdentifier usage in chrome/browser/resources/* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix chromeos build Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/login/screen_supervised_user_creation.js
diff --git a/chrome/browser/resources/chromeos/login/screen_supervised_user_creation.js b/chrome/browser/resources/chromeos/login/screen_supervised_user_creation.js
index a89c794033d9daffecc5c0497048804152b0fe8e..ab6709e2e2bf67ee3caeadbc6e643f5a80df1823 100644
--- a/chrome/browser/resources/chromeos/login/screen_supervised_user_creation.js
+++ b/chrome/browser/resources/chromeos/login/screen_supervised_user_creation.js
@@ -53,12 +53,12 @@ login.createScreen('SupervisedUserCreationScreen',
hideManagerPasswordError);
this.passwordElement.addEventListener('keydown', function(e) {
- switch (e.keyIdentifier) {
- case 'Up':
+ switch (e.key) {
+ case 'ArrowUp':
managerPodList.selectNextPod(-1);
e.stopPropagation();
break;
- case 'Down':
+ case 'ArrowDown':
managerPodList.selectNextPod(+1);
e.stopPropagation();
break;
@@ -345,8 +345,8 @@ login.createScreen('SupervisedUserCreationScreen',
});
this.addEventListener('keydown', function(e) {
- switch (e.keyIdentifier) {
- case 'Up':
+ switch (e.key) {
+ case 'ArrowUp':
importList.selectNextPod(-1);
e.stopPropagation();
break;
@@ -355,7 +355,7 @@ login.createScreen('SupervisedUserCreationScreen',
screen.importSupervisedUser_();
e.stopPropagation();
break;
- case 'Down':
+ case 'ArrowDown':
importList.selectNextPod(+1);
e.stopPropagation();
break;
@@ -682,7 +682,7 @@ login.createScreen('SupervisedUserCreationScreen',
moveFocus,
errorHider) {
element.addEventListener('keydown', function(e) {
- if (e.keyIdentifier == 'Enter') {
+ if (e.key == 'Enter') {
var dataValid = true;
if (validator)
dataValid = validator(element);
« no previous file with comments | « chrome/browser/resources/chromeos/keyboard/keyboard_utils.js ('k') | chrome/browser/resources/chromeos/sim_unlock.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698