chrome/browser/resources/options/inline_editable_list.js - Issue 2059913002: Remove keyIdentifier usage in chrome/browser/resources/*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/inline_editable_list.js

Issue 2059913002: Remove keyIdentifier usage in chrome/browser/resources/* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix chromeos build Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/options/home_page_overlay.js ('k') | chrome/browser/resources/options/language_dictionary_overlay.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/inline_editable_list.js

diff --git a/chrome/browser/resources/options/inline_editable_list.js b/chrome/browser/resources/options/inline_editable_list.js

index 4213cf298e91e52c8b28bafb0ed8b016f616e0f7..da5751e2719efb9eba3f2f007d01885ae0690c4c 100644

--- a/chrome/browser/resources/options/inline_editable_list.js

+++ b/chrome/browser/resources/options/inline_editable_list.js

@@ -480,8 +480,8 @@ cr.define('options', function() {

var endEdit = false;

var handledKey = true;

- switch (e.keyIdentifier) {

- case 'U+001B': // Esc

+ switch (e.key) {

+ case 'Escape':

this.editCancelled_ = true;

endEdit = true;

break;