chrome/browser/resources/sync_confirmation/sync_confirmation.js - Issue 2059913002: Remove keyIdentifier usage in chrome/browser/resources/*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/sync_confirmation/sync_confirmation.js

Issue 2059913002: Remove keyIdentifier usage in chrome/browser/resources/* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix chromeos build Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/options/language_options.js ('k') | chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_browsertest.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/sync_confirmation/sync_confirmation.js

diff --git a/chrome/browser/resources/sync_confirmation/sync_confirmation.js b/chrome/browser/resources/sync_confirmation/sync_confirmation.js

index 2e37139c2a94e97b84aabac698b7897c9281eecd..e22b4ddecc67c1dd4ebc7bdcea9dbb88703c9b5f 100644

--- a/chrome/browser/resources/sync_confirmation/sync_confirmation.js

+++ b/chrome/browser/resources/sync_confirmation/sync_confirmation.js

@@ -42,7 +42,7 @@ cr.define('sync.confirmation', function() {

// If the currently focused element isn't something that performs an action

// on "enter" being pressed and the user hits "enter", perform the default

// action of the dialog, which is "OK, Got It".

- if (e.keyIdentifier == 'Enter' &&

+ if (e.key == 'Enter' &&

!/^(A|PAPER-BUTTON)$/.test(document.activeElement.tagName)) {

$('confirmButton').click();

e.preventDefault();