Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1903)

Unified Diff: chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js

Issue 2059913002: Remove keyIdentifier usage in chrome/browser/resources/* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix chromeos build Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/chromeos/chromevox/cvox2/background/i_search.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js
diff --git a/chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js b/chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js
index 2f4d00eb67ffd8a8d25a5cf0a78a996779af9854..27c8e39862080321f83cd5077bfee60d40158469 100644
--- a/chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js
+++ b/chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js
@@ -479,8 +479,8 @@ cr.define('bmm', function() {
// Calling list.focus blurs the input which will stop editing the list
// item.
- switch (e.keyIdentifier) {
- case 'U+001B': // Esc
+ switch (e.key) {
+ case 'Escape': // Esc
labelInput.value = title;
if (!isFolder)
urlInput.value = url;
@@ -490,7 +490,7 @@ cr.define('bmm', function() {
if (listItem.parentNode)
listItem.parentNode.focus();
break;
- case 'U+0009': // Tab
+ case 'Tab': // Tab
// urlInput is the last focusable element in the page. If we
// allowed Tab focus navigation and the page loses focus, we
// couldn't give focus on urlInput programatically. So, we prevent
« no previous file with comments | « no previous file | chrome/browser/resources/chromeos/chromevox/cvox2/background/i_search.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698