Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3254)

Unified Diff: chrome/test/data/webui/link_controller_test.html

Issue 2059913002: Remove keyIdentifier usage in chrome/browser/resources/* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix chromeos build Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/data/keyevents_test.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/link_controller_test.html
diff --git a/chrome/test/data/webui/link_controller_test.html b/chrome/test/data/webui/link_controller_test.html
index 9dd2587161ed3a02854bdc0b76716edcb21d5044..9ab19211c6e7bc374c5cc6056b454f60f7cd8690 100644
--- a/chrome/test/data/webui/link_controller_test.html
+++ b/chrome/test/data/webui/link_controller_test.html
@@ -90,7 +90,7 @@ function testOpenUrlFromEventForegroundTabMac() {
function testOpenUrlFromEventForegroundTabEnter() {
var e = {
type: 'keydown',
- keyIdentifier: 'Enter',
+ key: 'Enter',
shiftKey: true,
ctrlKey: true
};
@@ -100,7 +100,7 @@ function testOpenUrlFromEventForegroundTabEnter() {
function testOpenUrlFromEventForegroundTabEnterMac() {
var e = {
type: 'keydown',
- keyIdentifier: 'Enter',
+ key: 'Enter',
shiftKey: true,
metaKey: true
};
@@ -139,7 +139,7 @@ function testOpenUrlFromEventBackgroundTabMac() {
function testOpenUrlFromEventBackgroundTabEnter() {
var e = {
type: 'keydown',
- keyIdentifier: 'Enter',
+ key: 'Enter',
ctrlKey: true
};
openUrlFromEventHelper(e, false, cr.LinkKind.BACKGROUND_TAB);
@@ -148,7 +148,7 @@ function testOpenUrlFromEventBackgroundTabEnter() {
function testOpenUrlFromEventBackgroundTabEnterMac() {
var e = {
type: 'keydown',
- keyIdentifier: 'Enter',
+ key: 'Enter',
metaKey: true
};
openUrlFromEventHelper(e, true, cr.LinkKind.BACKGROUND_TAB);
@@ -176,7 +176,7 @@ function testOpenUrlFromEventWindow() {
function testOpenUrlFromEventWindowEnter() {
var e = {
type: 'keydown',
- keyIdentifier: 'Enter',
+ key: 'Enter',
shiftKey: true
};
openUrlFromEventHelper(e, false, cr.LinkKind.WINDOW);
@@ -195,7 +195,7 @@ function testOpenUrlFromEventSelf() {
function testOpenUrlFromEventSelfEnter() {
var e = {
type: 'keydown',
- keyIdentifier: 'Enter'
+ key: 'Enter'
};
openUrlFromEventHelper(e, false, cr.LinkKind.SELF);
}
« no previous file with comments | « chrome/test/data/keyevents_test.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698