Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Unified Diff: chrome/browser/resources/options/cookies_list.js

Issue 2059913002: Remove keyIdentifier usage in chrome/browser/resources/* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix chromeos build Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/cookies_list.js
diff --git a/chrome/browser/resources/options/cookies_list.js b/chrome/browser/resources/options/cookies_list.js
index b68fc8d84f636d856d7505108e957d1a90c0554f..c3b97c214b82d71dc1b16b5f4814b0f153d72331 100644
--- a/chrome/browser/resources/options/cookies_list.js
+++ b/chrome/browser/resources/options/cookies_list.js
@@ -745,13 +745,13 @@ cr.define('options', function() {
* @private
*/
handleKeyLeftRight_: function(e) {
- var id = e.keyIdentifier;
+ var id = e.key;
if (e.altKey || e.ctrlKey || e.metaKey || e.shiftKey)
return;
- if ((id == 'Left' || id == 'Right') && this.expandedItem) {
+ if ((id == 'ArrowLeft' || id == 'ArrowRight') && this.expandedItem) {
var cs = this.ownerDocument.defaultView.getComputedStyle(this);
var rtl = cs.direction == 'rtl';
- if ((!rtl && id == 'Left') || (rtl && id == 'Right'))
+ if ((!rtl && id == 'ArrowLeft') || (rtl && id == 'ArrowRight'))
this.expandedItem.selectedIndex--;
else
this.expandedItem.selectedIndex++;
« no previous file with comments | « chrome/browser/resources/options/chromeos/network_list.js ('k') | chrome/browser/resources/options/cookies_view.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698