chrome/test/data/keyevents_test.html - Issue 2059913002: Remove keyIdentifier usage in chrome/browser/resources/*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/keyevents_test.html

Issue 2059913002: Remove keyIdentifier usage in chrome/browser/resources/* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix chromeos build Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/options/edit_dictionary_browsertest.js ('k') | chrome/test/data/webui/link_controller_test.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/keyevents_test.html

diff --git a/chrome/test/data/keyevents_test.html b/chrome/test/data/keyevents_test.html

index 88ba7a87de10a8717d2ad6eb460c3235173bf36a..1c5bc719db7f41758efcffaf463763ef1329729f 100644

--- a/chrome/test/data/keyevents_test.html

+++ b/chrome/test/data/keyevents_test.html

@@ -72,7 +72,7 @@ function handleEvent(e) {

// But Windows and Mac have opposite behavior than Linux.

// To make the C++ testing code simpler, if it's a modifier key event,

// then ignores the corresponding modifier attribute by setting it to true.

- var keyId = evt.keyIdentifier;

+ var keyId = evt.key;

result += (evt.keyCode + ' ' + evt.charCode + ' ' +

(keyId == 'Control' ? true : evt.ctrlKey) + ' ' +

(keyId == 'Shift' ? true : evt.shiftKey) + ' ' +

« no previous file with comments | « chrome/browser/ui/webui/options/edit_dictionary_browsertest.js ('k') | chrome/test/data/webui/link_controller_test.html » ('j') | no next file with comments »