|
Remove MessageLoop::current()->RunUntilIdle() in components.
This CL replaces MessageLoop::current()->RunUntilIdle() with
RunLoop().RunUntilIdle() in components.
In files where this replacement is made, it adds this include:
#include "base/run_loop.h"
And removes this include if it is no longer required:
#include "base/message_loop/message_loop.h"
Why?
- The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop but they will be able to use
RunLoop.
- MessageLoop::RunUntilIdle() is deprecated.
Steps to generate this patch:
1. Run message_loop_cleanup_3.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.
BUG= 616447
R=caitkp@chromium.org
Committed: https://crrev.com/87801424a57095d9d2e5dc4e5ffb6079771e36b2
Cr-Commit-Position: refs/heads/master@{#399099}
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+168 lines, -155 lines) |
Patch |
|
M |
components/browser_sync/browser/profile_sync_service_bookmark_unittest.cc
|
View
|
|
5 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
|
M |
components/browsing_data_ui/history_notice_utils_unittest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
components/data_reduction_proxy/content/browser/content_lofi_ui_service_unittest.cc
|
View
|
|
3 chunks |
+2 lines, -3 lines |
0 comments
|
Download
|
|
M |
components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc
|
View
|
|
2 chunks |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
components/data_usage/core/data_use_aggregator_unittest.cc
|
View
|
|
2 chunks |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
components/dom_distiller/core/distilled_content_store_unittest.cc
|
View
|
|
19 chunks |
+20 lines, -20 lines |
0 comments
|
Download
|
|
M |
components/dom_distiller/core/distiller_unittest.cc
|
View
|
|
19 chunks |
+21 lines, -20 lines |
0 comments
|
Download
|
|
M |
components/favicon/core/large_icon_service_unittest.cc
|
View
|
|
10 chunks |
+10 lines, -9 lines |
0 comments
|
Download
|
|
M |
components/google/core/browser/google_url_tracker_unittest.cc
|
View
|
|
2 chunks |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
components/history/core/browser/expire_history_backend_unittest.cc
|
View
|
|
2 chunks |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
components/history/core/browser/history_backend_db_unittest.cc
|
View
|
|
2 chunks |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
components/omnibox/browser/shortcuts_provider_test_util.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
components/password_manager/core/browser/password_store_default_unittest.cc
|
View
|
|
9 chunks |
+16 lines, -16 lines |
0 comments
|
Download
|
|
M |
components/password_manager/core/browser/password_store_unittest.cc
|
View
|
|
19 chunks |
+25 lines, -24 lines |
0 comments
|
Download
|
|
M |
components/precache/content/precache_manager_unittest.cc
|
View
|
|
19 chunks |
+28 lines, -28 lines |
0 comments
|
Download
|
|
M |
components/rappor/log_uploader_unittest.cc
|
View
|
|
6 chunks |
+7 lines, -6 lines |
0 comments
|
Download
|
|
M |
components/safe_browsing_db/v4_database_unittest.cc
|
View
|
|
4 chunks |
+4 lines, -3 lines |
0 comments
|
Download
|
|
M |
components/search_engines/search_engine_data_type_controller_unittest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
components/suggestions/suggestions_service_unittest.cc
|
View
|
|
3 chunks |
+6 lines, -5 lines |
0 comments
|
Download
|
|
M |
components/sync_bookmarks/bookmark_data_type_controller_unittest.cc
|
View
|
|
2 chunks |
+2 lines, -3 lines |
0 comments
|
Download
|
|
M |
components/sync_driver/frontend_data_type_controller_unittest.cc
|
View
|
|
2 chunks |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
components/sync_driver/non_ui_data_type_controller_unittest.cc
|
View
|
|
2 chunks |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
components/translate/core/browser/translate_manager_unittest.cc
|
View
|
|
2 chunks |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
components/web_resource/resource_request_allowed_notifier_unittest.cc
|
View
|
|
2 chunks |
+2 lines, -1 line |
0 comments
|
Download
|
Total messages: 6 (2 generated)
|