components/history/core/browser/expire_history_backend_unittest.cc - Issue 2053913002: Remove MessageLoop::current()->RunUntilIdle() in components.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/history/core/browser/expire_history_backend_unittest.cc

Issue 2053913002: Remove MessageLoop::current()->RunUntilIdle() in components. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/google/core/browser/google_url_tracker_unittest.cc ('k') | components/history/core/browser/history_backend_db_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/history/core/browser/expire_history_backend_unittest.cc

diff --git a/components/history/core/browser/expire_history_backend_unittest.cc b/components/history/core/browser/expire_history_backend_unittest.cc

index 6fc9b4272c207f92deb7047531b1f7c22c4f1197..ee87550e85b5a17b9e0fef554f00aa236027398b 100644

--- a/components/history/core/browser/expire_history_backend_unittest.cc

+++ b/components/history/core/browser/expire_history_backend_unittest.cc

@@ -17,6 +17,7 @@

#include "base/files/scoped_temp_dir.h"

#include "base/macros.h"

#include "base/message_loop/message_loop.h"

+#include "base/run_loop.h"

#include "base/scoped_observer.h"

#include "base/strings/string16.h"

#include "base/strings/utf_string_conversions.h"

@@ -155,7 +156,7 @@ class ExpireHistoryTest : public testing::Test, public HistoryBackendNotifier {

top_sites_ = nullptr;

if (base::MessageLoop::current())

- base::MessageLoop::current()->RunUntilIdle();

+ base::RunLoop().RunUntilIdle();

pref_service_.reset();

}