components/sync_bookmarks/bookmark_data_type_controller_unittest.cc - Issue 2053913002: Remove MessageLoop::current()->RunUntilIdle() in components.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync_bookmarks/bookmark_data_type_controller_unittest.cc

Issue 2053913002: Remove MessageLoop::current()->RunUntilIdle() in components. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/suggestions/suggestions_service_unittest.cc ('k') | components/sync_driver/frontend_data_type_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/sync_bookmarks/bookmark_data_type_controller_unittest.cc

diff --git a/components/sync_bookmarks/bookmark_data_type_controller_unittest.cc b/components/sync_bookmarks/bookmark_data_type_controller_unittest.cc

index 4430ee6d1c11fe6026a6e9431114d24dd14e7d61..b2d379423300822405c9530edde2418e73309022 100644

--- a/components/sync_bookmarks/bookmark_data_type_controller_unittest.cc

+++ b/components/sync_bookmarks/bookmark_data_type_controller_unittest.cc

@@ -128,7 +128,7 @@ class SyncBookmarkDataTypeControllerTest : public testing::Test,

bookmark_dtc_->StartAssociating(

base::Bind(&StartCallbackMock::Run,

base::Unretained(&start_callback_)));

- base::MessageLoop::current()->RunUntilIdle();

+ base::RunLoop().RunUntilIdle();

}

void NotifyHistoryServiceLoaded() {

@@ -180,8 +180,7 @@ TEST_F(SyncBookmarkDataTypeControllerTest, StartBookmarkModelNotReady) {

bookmark_dtc_->StartAssociating(

base::Bind(&StartCallbackMock::Run,

base::Unretained(&start_callback_)));

- base::MessageLoop::current()->RunUntilIdle();

+ base::RunLoop().RunUntilIdle();

EXPECT_EQ(DataTypeController::RUNNING, bookmark_dtc_->state());

}