components/web_resource/resource_request_allowed_notifier_unittest.cc - Issue 2053913002: Remove MessageLoop::current()->RunUntilIdle() in components.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/web_resource/resource_request_allowed_notifier_unittest.cc

Issue 2053913002: Remove MessageLoop::current()->RunUntilIdle() in components. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/web_resource/resource_request_allowed_notifier_unittest.cc

diff --git a/components/web_resource/resource_request_allowed_notifier_unittest.cc b/components/web_resource/resource_request_allowed_notifier_unittest.cc

index 45ffa9a7590b64c8b3736fc59ab39cc6224bd12d..78ceb33f416ff1874b7ee3f9e36510400766a08a 100644

--- a/components/web_resource/resource_request_allowed_notifier_unittest.cc

+++ b/components/web_resource/resource_request_allowed_notifier_unittest.cc

@@ -4,6 +4,7 @@

#include "base/macros.h"

#include "base/memory/ptr_util.h"

+#include "base/run_loop.h"

#include "components/prefs/testing_pref_service.h"

#include "components/web_resource/eula_accepted_notifier.h"

#include "components/web_resource/resource_request_allowed_notifier_test_util.h"

@@ -27,7 +28,7 @@ class TestNetworkChangeNotifier : public net::NetworkChangeNotifier {

connection_type_to_return_ = type;

net::NetworkChangeNotifier::NotifyObserversOfConnectionTypeChangeForTests(

connection_type_to_return_);

- base::MessageLoop::current()->RunUntilIdle();

+ base::RunLoop().RunUntilIdle();

}

private:

« no previous file with comments | « components/translate/core/browser/translate_manager_unittest.cc ('k') | no next file » | no next file with comments »