components/data_reduction_proxy/content/browser/content_lofi_ui_service_unittest.cc - Issue 2053913002: Remove MessageLoop::current()->RunUntilIdle() in components.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/content/browser/content_lofi_ui_service_unittest.cc

Issue 2053913002: Remove MessageLoop::current()->RunUntilIdle() in components. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/browsing_data_ui/history_notice_utils_unittest.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/content/browser/content_lofi_ui_service_unittest.cc

diff --git a/components/data_reduction_proxy/content/browser/content_lofi_ui_service_unittest.cc b/components/data_reduction_proxy/content/browser/content_lofi_ui_service_unittest.cc

index 8d8be306042a778f3d2c7b59302036e73ff1c364..22699f3282462bf4b206b66391bd21824eb3ca4c 100644

--- a/components/data_reduction_proxy/content/browser/content_lofi_ui_service_unittest.cc

+++ b/components/data_reduction_proxy/content/browser/content_lofi_ui_service_unittest.cc

@@ -11,7 +11,6 @@

#include "base/bind.h"

#include "base/bind_helpers.h"

#include "base/macros.h"

-#include "base/message_loop/message_loop.h"

#include "base/run_loop.h"

#include "content/public/browser/browser_thread.h"

#include "content/public/browser/render_frame_host.h"

@@ -110,7 +109,7 @@ TEST_F(ContentLoFiUIServiceTest, OnLoFiResponseReceived) {

base::Bind(&ContentLoFiUIServiceTest::RunTestOnIOThread,

base::Unretained(this), &ui_run_loop, false));

ui_run_loop.Run();

- base::MessageLoop::current()->RunUntilIdle();

+ base::RunLoop().RunUntilIdle();

VerifyOnLoFiResponseReceivedCallback(false);

}

@@ -121,7 +120,7 @@ TEST_F(ContentLoFiUIServiceTest, OnLoFiPreviewResponseReceived) {

base::Bind(&ContentLoFiUIServiceTest::RunTestOnIOThread,

base::Unretained(this), &ui_run_loop, true));

ui_run_loop.Run();

- base::MessageLoop::current()->RunUntilIdle();

+ base::RunLoop().RunUntilIdle();

VerifyOnLoFiResponseReceivedCallback(true);

}