components/sync_driver/non_ui_data_type_controller_unittest.cc - Issue 2053913002: Remove MessageLoop::current()->RunUntilIdle() in components.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync_driver/non_ui_data_type_controller_unittest.cc

Issue 2053913002: Remove MessageLoop::current()->RunUntilIdle() in components. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/sync_driver/frontend_data_type_controller_unittest.cc ('k') | components/translate/core/browser/translate_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/sync_driver/non_ui_data_type_controller_unittest.cc

diff --git a/components/sync_driver/non_ui_data_type_controller_unittest.cc b/components/sync_driver/non_ui_data_type_controller_unittest.cc

index e4c69a03a8ff2d6e3bc3293f233b8eb3f85372a8..b18f0506c2742873f4b22e157bbb9c13aaf354e0 100644

--- a/components/sync_driver/non_ui_data_type_controller_unittest.cc

+++ b/components/sync_driver/non_ui_data_type_controller_unittest.cc

@@ -13,6 +13,7 @@

#include "base/compiler_specific.h"

#include "base/location.h"

#include "base/macros.h"

+#include "base/run_loop.h"

#include "base/single_thread_task_runner.h"

#include "base/synchronization/waitable_event.h"

#include "base/test/test_timeouts.h"

@@ -211,7 +212,7 @@ class SyncNonUIDataTypeControllerTest : public testing::Test,

if (!done.IsSignaled()) {

ADD_FAILURE() << "Timed out waiting for DB thread to finish.";

}

- base::MessageLoop::current()->RunUntilIdle();

+ base::RunLoop().RunUntilIdle();

}

SyncService* GetSyncService() override {