components/browsing_data_ui/history_notice_utils_unittest.cc - Issue 2053913002: Remove MessageLoop::current()->RunUntilIdle() in components.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/browsing_data_ui/history_notice_utils_unittest.cc

Issue 2053913002: Remove MessageLoop::current()->RunUntilIdle() in components. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/browser_sync/browser/profile_sync_service_bookmark_unittest.cc ('k') | components/data_reduction_proxy/content/browser/content_lofi_ui_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/browsing_data_ui/history_notice_utils_unittest.cc

diff --git a/components/browsing_data_ui/history_notice_utils_unittest.cc b/components/browsing_data_ui/history_notice_utils_unittest.cc

index e850b74f2f8d6f152ae585a14556d0bc5894b006..725a308029fd87524ece006a58c991f187ab0eb1 100644

--- a/components/browsing_data_ui/history_notice_utils_unittest.cc

+++ b/components/browsing_data_ui/history_notice_utils_unittest.cc

@@ -106,7 +106,7 @@ class HistoryNoticeUtilsTest : public ::testing::Test {

// Process the DeleteSoon() called on MergeBooleanCallbacks, otherwise

// this it will be considered to be leaked.

- base::MessageLoop::current()->RunUntilIdle();

+ base::RunLoop().RunUntilIdle();

EXPECT_EQ(expected_test_case_result, result_);

}