components/safe_browsing_db/v4_database_unittest.cc - Issue 2053913002: Remove MessageLoop::current()->RunUntilIdle() in components.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/safe_browsing_db/v4_database_unittest.cc

Issue 2053913002: Remove MessageLoop::current()->RunUntilIdle() in components. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/rappor/log_uploader_unittest.cc ('k') | components/search_engines/search_engine_data_type_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/safe_browsing_db/v4_database_unittest.cc

diff --git a/components/safe_browsing_db/v4_database_unittest.cc b/components/safe_browsing_db/v4_database_unittest.cc

index 31dfe1548585f51d6ba348537a5737f4832dd5e8..83ea5f41224802a4e7b4991ec6283ef5f2ab21d5 100644

--- a/components/safe_browsing_db/v4_database_unittest.cc

+++ b/components/safe_browsing_db/v4_database_unittest.cc

@@ -6,6 +6,7 @@

#include "base/debug/leak_annotations.h"

#include "base/files/scoped_temp_dir.h"

#include "base/memory/ptr_util.h"

+#include "base/run_loop.h"

#include "base/test/test_simple_task_runner.h"

#include "components/safe_browsing_db/v4_database.h"

#include "components/safe_browsing_db/v4_store.h"

@@ -136,7 +137,7 @@ TEST_F(SafeBrowsingV4DatabaseTest, TestSetupDatabaseWithNoStores) {

created_but_not_called_back_ = true;

task_runner_->RunPendingTasks();

- base::MessageLoop::current()->RunUntilIdle();

+ base::RunLoop().RunUntilIdle();

EXPECT_EQ(true, created_and_called_back_);

}

@@ -157,7 +158,7 @@ TEST_F(SafeBrowsingV4DatabaseTest, TestSetupDatabaseWithFakeStores) {

created_but_not_called_back_ = true;

task_runner_->RunPendingTasks();

- base::MessageLoop::current()->RunUntilIdle();

+ base::RunLoop().RunUntilIdle();

EXPECT_EQ(true, created_and_called_back_);

}

@@ -178,7 +179,7 @@ TEST_F(SafeBrowsingV4DatabaseTest, TestSetupDatabaseWithFakeStoresFailsReset) {

created_but_not_called_back_ = true;

task_runner_->RunPendingTasks();

- base::MessageLoop::current()->RunUntilIdle();

+ base::RunLoop().RunUntilIdle();

EXPECT_EQ(true, created_and_called_back_);

}