components/google/core/browser/google_url_tracker_unittest.cc - Issue 2053913002: Remove MessageLoop::current()->RunUntilIdle() in components.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/google/core/browser/google_url_tracker_unittest.cc

Issue 2053913002: Remove MessageLoop::current()->RunUntilIdle() in components. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/favicon/core/large_icon_service_unittest.cc ('k') | components/history/core/browser/expire_history_backend_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/google/core/browser/google_url_tracker_unittest.cc

diff --git a/components/google/core/browser/google_url_tracker_unittest.cc b/components/google/core/browser/google_url_tracker_unittest.cc

index 64eea7636d7e83daa5dc6afb7efacbb269e9f1f7..f6c325a00f8dcbef35aba8ac8a11537fe0f5124f 100644

--- a/components/google/core/browser/google_url_tracker_unittest.cc

+++ b/components/google/core/browser/google_url_tracker_unittest.cc

@@ -9,6 +9,7 @@

#include <utility>

#include "base/macros.h"

+#include "base/run_loop.h"

#include "base/threading/thread_task_runner_handle.h"

#include "components/google/core/browser/google_pref_names.h"

#include "components/google/core/browser/google_url_tracker_client.h"

@@ -200,7 +201,7 @@ void GoogleURLTrackerTest::NotifyNetworkChanged() {

net::NetworkChangeNotifier::CONNECTION_UNKNOWN);

// For thread safety, the NCN queues tasks to do the actual notifications, so

// we need to spin the message loop so the tracker will actually be notified.

- base::MessageLoop::current()->RunUntilIdle();

+ base::RunLoop().RunUntilIdle();

}

// Tests ----------------------------------------------------------------------